Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music Style strings removal from main translation file #2748

Open
15 of 22 tasks
tupaschoal opened this issue Feb 17, 2024 · 12 comments
Open
15 of 22 tasks

Music Style strings removal from main translation file #2748

tupaschoal opened this issue Feb 17, 2024 · 12 comments

Comments

@tupaschoal
Copy link
Member

tupaschoal commented Feb 17, 2024

On PR OpenRCT2/OpenRCT2#21385 we removed the Music Style Strings from the en-GB translation file, since they are now being sourced from the object translation file.

On #2741 we removed it from all other translations, but we didn't cross-check to see whether these translations had been applied to the corresponding language objects translation file or if they were more up-to-date.

Since it takes a language speaker to verify, please check the removed strings for your language on the PR #2741 were already applied to objects/<LANG>.json or if any of those need updating.

  • If everything is fine, just comment here the language you checked so we can tick it
  • If you find it needs updating, open a PR as you would for any other translation

Updated in:

  • ar-EG
  • ca-ES
  • cs-CZ
  • da-DK
  • de-DE
  • en-US
  • eo-ZZ
  • es-ES
  • fi-FI
  • fr-FR
  • hu-HU
  • it-IT
  • ja-JP
  • ko-KR
  • nb-NO
  • nl-NL
  • pl-PL
  • pt-BR
  • sv-SE
  • tr-TR
  • zh-CN
  • zh-TW

Notification when new strings arrive:
@Omaranwa @J0anJosep @LPSGizmo @Wuzzy2 @Gr33ndev @tellovishous @dimateos @groenroos @rmnvgr @LucaRed @telk5093 @Mmmmulder @Gymnasiast @marcinkunert @tupaschoal @LPR-Michael @daihakken

@telk5093
Copy link
Contributor

ko-KR is fine

@tupaschoal
Copy link
Member Author

pt-BR is ok

@rmnvgr
Copy link
Contributor

rmnvgr commented Feb 18, 2024

fr-FR is good

@groenroos
Copy link
Contributor

fi-FI is good

@tellovishous
Copy link
Contributor

eo-ZZ looks good to me

dimateos added a commit to dimateos/Open-RCT2-Localisation that referenced this issue Feb 19, 2024
Gymnasiast pushed a commit that referenced this issue Feb 19, 2024
@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Feb 19, 2024

de-DE is okay.

@Mmmmulder
Copy link
Contributor

nb-NO is ok

@LPSGizmo
Copy link
Contributor

da-DK is ok

@LucaRed
Copy link
Contributor

LucaRed commented Feb 29, 2024

it-IT is ok

@daihakken
Copy link
Contributor

zh-TW is fine.

@J0anJosep
Copy link
Contributor

ca-ES is OK.

@mrmagic2020
Copy link
Contributor

zh-CN is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests