Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The copies is lost #586

Open
szlt5 opened this issue May 29, 2024 · 3 comments
Open

The copies is lost #586

szlt5 opened this issue May 29, 2024 · 3 comments

Comments

@szlt5
Copy link

szlt5 commented May 29, 2024

This issue is caused by the fix of issue331

Details:
[OS]: Debian12
[cups-filter]: 1.28.17-3
[Test Application]: gedit, evince

The document-format-supported attribute returned by the device includes application/pdf and image/urf. Then driverless generated the following ppd (Note: cupsManualCopies information is not recorded in the ppd):

*cupsFillter2: "application/vnd.cups-pdf application/pdf 200 -"
*cupsFilter2: "image/urf image/urf 0 -"

Printing with copies =N (N>=2), the following filters will be called: pdftopdf -> gstoraster -> rastertopwg -> ipp (backend).

Because cupsManualCopies is not true, pdftopdf filter will not perform the software copies. At the same time, when ipp backend sends image/urf data to device, the copies are set as 1. (https://github.com/OpenPrinting/cups/blob/d91acd4429ff85958545820e7c71c33fcab6884e/cups/ppd-cache.c#L377).

There is no such issue for everywhere because michaelrsweet rejected the merge: OpenPrinting/cups#310.

@szlt5
Copy link
Author

szlt5 commented May 29, 2024

Theoretically gstoraster will write the number of copies in the head of raster image (pwg-raster or urf). However, the head of pwg-raster will contain copies information, but image/urf does not have this capability.

https://github.com/OpenPrinting/libcups/blob/b476901bc574ee6ceb44a9cf027d06a5494ed96e/cups/raster-stream.c#L1113
https://github.com/OpenPrinting/libcups/blob/b476901bc574ee6ceb44a9cf027d06a5494ed96e/cups/raster-stream.c#L1137

@zdohnal
Copy link
Member

zdohnal commented May 29, 2024

I have tried to reproduce it with the latest release - cups-filters 2.0.0 - and the issue is not present.

@szlt5
Copy link
Author

szlt5 commented May 29, 2024

I have tried to reproduce it with the latest release - cups-filters 2.0.0 - and the issue is not present.

Yes, this issue only happens at cups-filters 1.28.17 on the latest Debian OS.

OpenPrinting/libppd#42 happens at cups-filters 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants