InvalidArgument: A specified parameter was not correct: deviceChange[1].device.key" - vCenter adding two NICs

[markush81]

Description
Attaching two NICs with vCenter results into an InvalidArgument error.

deploy: Deploy of VM 16 on vCenter cluster Cluster1 with /var/lib/one/vms/16/deployment.0 failed due to 
"InvalidArgument: A specified parameter was not correct: deviceChange[1].device.key"on attempt #2.

To Reproduce
Instantiate a template and adding (or template already has) two NICs attached.

Expected behavior
Virtual machines is being created without errors.

Details

• Affected Component: vCenter Driver
• Hypervisor: vCenter 7.0
• Version: 6.8.3

Additional context

So i might have identified already where it fails:

• the device_change contains two devices with same key -101.
• calculate_add_nic_spec is calculating a card_num based on @item['config.hardware.device'] which on a new vm seems to never contain the NIC devices, this results into same number for card_spec[:key] = -100 - card_num.to_i
• on the other hand i found code calculating a @unic but it is never used
• using @uniqc at card_spec[:key] = -100 - @uniqc.to_i and :label => 'net' + @uniqc.to_s, gives the expected result (not sure if first place plays a role.

So this already could be the fix needed. I am not sure what about the other part when converting to a template. calculate_add_nic_spec_autogenerate_mac

Progress Status

• Code committed
• Testing - QA
• Documentation (Release notes - resolved issues, compatibility, known issues)