Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B: KVM Migration fails if CLEANUP_MEMORY_ON_STOP is not defined #6665

Closed
3 tasks
onenhansen opened this issue Jul 23, 2024 · 0 comments
Closed
3 tasks

B: KVM Migration fails if CLEANUP_MEMORY_ON_STOP is not defined #6665

onenhansen opened this issue Jul 23, 2024 · 0 comments
Labels
Category: KVM Priority: Normal Status: Accepted Type: Bug
Milestone
Release 6.10.1

Comments

@onenhansen
Copy link
Contributor

Description
KVM migrations fail when kvmrc does not have CLEANUP_MEMORY_ON_STOP defined in it

To Reproduce
Comment out CLEANUP_MEMORY_ON_STOP and

Expected behavior
Should have a default if it doesn't exist

Details

  • Affected Component: VM_MAD
  • Hypervisor: KVM
  • Version: 6.8

Additional context
https://github.com/OpenNebula/one-ee/blob/one-6.8/src/vmm_mad/remotes/kvm/migrate#L255

Up a few lines on line 234 there is another reference to SYNC_TIME so that could also be an issue if it's not defined in that file.

Progress Status

  • Code committed
  • Testing - QA
  • Documentation (Release notes - resolved issues, compatibility, known issues)
rsmontero added a commit to OpenNebula/docs that referenced this issue Sep 3, 2024
@rsmontero
B OpenNebula/one#6665: Resolved issues
e276e5f
rsmontero added a commit that referenced this issue Sep 3, 2024
@rsmontero
B ##6665: Fix missing CLEANUP_MEMORY_ON_STOP for KVM migrations
4c7f6dc 
Fix is the same applied here: c9742ad3d798e3c (use to_s to prevent
nil.upcase calls)
@rsmontero rsmontero added this to the Release 6.10.1 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: KVM Priority: Normal Status: Accepted Type: Bug
Projects
None yet
Milestone
Release 6.10.1
Development

No branches or pull requests
2 participants
@rsmontero @onenhansen