Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#79 dramatically worsened simulation times and causes large simulation errors #80

Open
casella opened this issue Mar 20, 2024 · 6 comments
Assignees

Comments

@casella
Copy link
Collaborator

casella commented Mar 20, 2024

@adrpo, please check https://libraries.openmodelica.org/branches/history/master-fmi-fmpy/2024-03-18%2022:22:01..2024-03-19%2020:08:50.html. Apparently, many simulations went from a few seconds to fifty-something.

I'm not sure if this is just a glitch in reporting, these timings are a bit suspicious. How can we check?

@casella
Copy link
Collaborator Author

casella commented Mar 20, 2024

The 50 s timeout likely plays some role, but we still get successful simulation and verification, so it's not failing. Not sure what is going on.

@adrpo
Copy link
Member

adrpo commented Mar 20, 2024

I remember you said that if you have and output-interval as non integer that it would get stuck, maybe this is what it happens and the timeout just forces to finish (correctly).

@casella
Copy link
Collaborator Author

casella commented Mar 22, 2024

Yes, that could be, see CATIA-Systems/FMPy#655.

But then how comes we still get the verification right? Could it be that it is still using the previously computed result file? If so, then you should probably update the test script to delete all such file before starting the new simulation.

@adrpo
Copy link
Member

adrpo commented Mar 26, 2024

Yes, that could be, see CATIA-Systems/FMPy#655.

But then how comes we still get the verification right? Could it be that it is still using the previously computed result file? If so, then you should probably update the test script to delete all such file before starting the new simulation.

We always delete the previous results so that's not the case.
It is possible that the simulation is finished in way less time that 50 but is stuck, so the result files are correct when is killed.

@casella
Copy link
Collaborator Author

casella commented Mar 27, 2024

OK. Any clue what is actually going on there?

@casella
Copy link
Collaborator Author

casella commented Mar 30, 2024

One more piece of info: many of those models timing out fail on verification with really weird results, e.g.:

immagine

Something's really weird going on there. @adrpo, how can we debug this? Can you try to run the same fmpy command line on your computer and see what the result is?

@casella casella changed the title #79 dramatically worsened simulation times #79 dramatically worsened simulation times and causes large simulation errors Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants