Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSV-compare tool to version 2.1.0 #128

Open
casella opened this issue Sep 25, 2024 · 3 comments
Open

Update CSV-compare tool to version 2.1.0 #128

casella opened this issue Sep 25, 2024 · 3 comments
Assignees

Comments

@casella
Copy link
Collaborator

casella commented Sep 25, 2024

We just released version 2.1.0 of CSV-compare. This has two new important features to avoid false negative, that we discussed in the MAP-Lib group:

We should update our CI to use this new version, so we avoid false negative in the verification results. This should be done ASAP, so we can do the regression testing for 4.1.0 before we tag the RC version mid-October

@adrpo
Copy link
Member

adrpo commented Sep 25, 2024

Currently we have the C# code translated to the C code at: https://github.com/OpenModelica/OpenModelica/blob/master/OMCompiler/Compiler/runtime/SimulationResultsCmpTubes.c
so we would need to update that.

@sjoelund: would it be possible to use mono and run the C# tool to do the diff. I know, is yet another dependency for the testing suite.

@sjoelund
Copy link
Member

sjoelund commented Sep 25, 2024

It might be, but the diff tool at least when I translated it didn't have any interface to get the curves and create our own output. It was just those very large reports of multiple HTML files that were produced. You even need to parse the HTML to see if it succeeded or not IIRC.

The other problem is it might need to be adapted to Linux as well. It had hard-coded \\ for path separators, etc instead of using joinpath-style code.

It is anyway not a hard dependency, but a Suggests or something for Ubuntu, so it wouldn't need to be installed by everyone.

@casella
Copy link
Collaborator Author

casella commented Sep 25, 2024

I think fixing the first issue on the existing codebase (the tube widths) is a no brainer. Thomas applied some refactoring to the C# source code, but I guess it's not really necessary to do that, we just need to change 1e-12 to 1e-3 in a couple places.

The second issue is a bit harder, I understand the fix by Thomas was non-trivial. Eventually, when we introduce proper annotations to specify a shorter StopTime for verification, it won't be necessary anymore.

Maybe I can try the first fix myself, then we see what happens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants