Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel searching match for the player #12

Open
Relrin opened this issue Sep 22, 2018 · 0 comments
Open

Cancel searching match for the player #12

Relrin opened this issue Sep 22, 2018 · 0 comments
Labels
help wanted Extra attention is needed missing feature

Comments

@Relrin
Copy link
Member

Relrin commented Sep 22, 2018

An existing codebase of matchmaking microservice provides a way (at least for now only internally) to delete the player from search queues. All utility code for cancel searching is already written, however it will be great to provide an access via incoming requests to cancel the search.

So, for considering this feature as prepared and ready to use, you will need:

  • Append a new endpoint to router with a list of the required permissions
  • Write tests with coverage the most common and some corner cases (like an attempt to cancel the search, when the player isn't in a queue)
@Relrin Relrin added help wanted Extra attention is needed missing feature labels Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed missing feature
Projects
None yet
Development

No branches or pull requests

1 participant