-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching the code there are still some strftimes
present:
#4398
Comments
It's not so straight forward to replace |
I think it is not necessary to add this library, but simply use the date function, with some precautions. I have little time now, but if there is no PR, as soon as I can I will do mine |
We can consider to replace all date functions with https://github.com/briannesbitt/Carbon |
What should we do about this? magento-lts/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Date/Short.php Lines 21 to 33 in 593ce77
The config source isn't used in Magento, and while we could change the label to not rely on just mark the class as deprecated? |
Mark it
Which looks like the options in a dropdown for configuring date formatting, which is specific for |
Originally posted by @boesbo in #2934 (comment)
The text was updated successfully, but these errors were encountered: