Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with ENV-variables override #4257

Open
sreichel opened this issue Oct 8, 2024 · 3 comments
Open

Issues with ENV-variables override #4257

sreichel opened this issue Oct 8, 2024 · 3 comments

Comments

@sreichel
Copy link
Contributor

sreichel commented Oct 8, 2024

          Also did some tests ...
  • not working if DB value exists
  • Mage::getStoreConfig() does not work
  • store config with overriden values should not have set "use default"
  • store config with overriden values should be locked (to make it impossible to override ENV var with config)
  • test fail for live data (rewritten tests to use installed OM)

Originally posted by @sreichel in #3863 (comment)

@sreichel
Copy link
Contributor Author

sreichel commented Dec 7, 2024

@pquerner hey. Had you some time to review this?

@pquerner
Copy link
Contributor

pquerner commented Dec 7, 2024

No. I'm currently loaded with other projects. Its best if the feature is disabled for now. (Its in a helper, and can be early returned)

I am thinking that I will have some time over the coming holidays / new year and will get back to you asap.

@sreichel
Copy link
Contributor Author

sreichel commented Dec 7, 2024

Best X-mas wishes 🎄 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants