Skip to content

Commit d8ccd5d

Browse files
author
jkirk5
committed
CI fixes
Addressed review comments
1 parent 952e499 commit d8ccd5d

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

aviary/docs/getting_started/onboarding_level1.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@
223223
"\n",
224224
"To find information about a variable (e.g. description, data type, etc.), users should read the [Variable Metadata Doc](../user_guide/variable_metadata).\n",
225225
"\n",
226-
"Variable names may be differently within the code from how they are formatted inside OpenMDAO components and in input files and outputs. For example, variable `aircraft:wing:aspect_ratio` in `aircraft_for_bench_GwGm.csv` is mapped to `Aircraft.Wing.ASPECT_RATIO` in `aviary/variable_info/variable_meta_data.py`. This is because OpenMDAO requires variable names to be strings, but for developer convenience those strings are mapped to Python classes and attributes. The top-level and sub-categories have capitalized first letters, and the final variable name is always in all-caps. For more information on Aviary's variable hierarchy, see the [Variable Hierarchy doc](../user_guide/variable_hierarchy.ipynb).\n",
226+
"Variable names may appear differently within the code from how they are formatted inside OpenMDAO components and in input files and outputs. For example, variable `aircraft:wing:aspect_ratio` in `aircraft_for_bench_GwGm.csv` is mapped to `Aircraft.Wing.ASPECT_RATIO` in `aviary/variable_info/variable_meta_data.py`. This is because OpenMDAO requires variable names to be strings, but for developer convenience those strings are mapped to Python classes and attributes. The top-level and sub-categories have capitalized first letters, and the final variable name is always in all-caps. For more information on Aviary's variable hierarchy, see the [Variable Hierarchy doc](../user_guide/variable_hierarchy.ipynb).\n",
227227
"\n",
228228
"Aviary variables that are not defined in the `.csv` input file are set to their default values, as described in the variable metadata."
229229
]

aviary/subsystems/mass/gasp_based/test/test_fixed.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ def test_case_1(self):
642642
) # bug fixed value and original value
643643

644644
partial_data = self.prob.check_partials(out_stream=None, method="cs")
645-
assert_check_partials(partial_data, atol=1e-10, rtol=1e-10)
645+
assert_check_partials(partial_data, atol=1e-8, rtol=1e-8)
646646

647647

648648
class TailTestCase(unittest.TestCase): # this is the large single aisle 1 V3 test case

aviary/utils/preprocessors.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,8 +359,10 @@ def preprocess_propulsion(
359359
# update aviary options and outputs with new vectors
360360
# if data is numerical, store in a numpy array
361361
# keep tuples as tuples, lists get converted to numpy arrays
362-
if type(vec[0]) in (int, float, np.int64, np.float64)\
363-
and type(vec) is not tuple:
362+
if (
363+
type(vec[0]) in (int, float, np.int32, np.int64, np.float32, np.float64)
364+
and type(vec) is not tuple
365+
):
364366
vec = np.array(vec, dtype=dtype)
365367
aviary_options.set_val(var, vec, units)
366368

0 commit comments

Comments
 (0)