Skip to content

Commit e2ac55f

Browse files
committed
Upgrade to Java 17, adding FindByRank IT
1 parent a78c395 commit e2ac55f

File tree

3 files changed

+47
-2
lines changed

3 files changed

+47
-2
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<properties>
1212
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1313
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
14-
<maven.compiler.source>1.8</maven.compiler.source>
15-
<maven.compiler.target>1.8</maven.compiler.target>
14+
<maven.compiler.source>17</maven.compiler.source>
15+
<maven.compiler.target>17</maven.compiler.target>
1616
<!-- Plugins -->
1717
<version.liberty-maven-plugin>3.10</version.liberty-maven-plugin>
1818
<!-- OpenLiberty runtime -->

src/main/java/io/openliberty/sample/application/CrewMembers.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
/*******************************************************************************
2+
* Copyright (c) 2023 IBM Corporation and others.
3+
* All rights reserved. This program and the accompanying materials
4+
* are made available under the terms of the Eclipse Public License v1.0
5+
* which accompanies this distribution, and is available at
6+
* http://www.eclipse.org/legal/epl-v10.html
7+
*
8+
* Contributors:
9+
* IBM Corporation - initial API and implementation
10+
*******************************************************************************/
111
package io.openliberty.sample.application;
212

313
import java.util.List;

src/test/java/io/openliberty/sample/it/CrewServiceIT.java

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,41 @@ public void testFindByRank() {
183183

184184
}
185185

186+
/**
187+
* Test findByShipSizeAndRank, currently expects ordering to remain the same, which the spec doesn't require.
188+
*/
189+
@Test
190+
public void testFindByShipSizeAndRank() {
191+
response = client.target(baseURL + "db/crew/it1").request().post(Entity.json("{\"name\":\"Mark\",\"rank\":\"Engineer\",\"crewID\":75,\"ship\":\"Liberty Saucer\"}"));
192+
assertEquals(200, response.getStatus(), "output: " + response.readEntity(String.class));
193+
response = client.target(baseURL + "db/crew/it2").request().post(Entity.json("{\"name\":\"Jim\",\"rank\":\"Captain\",\"crewID\":64,\"ship\":\"Liberty Saucer\"}"));
194+
assertEquals(200, response.getStatus(), "output: " + response.readEntity(String.class));
195+
response = client.target(baseURL + "db/crew/it3").request().post(Entity.json("{\"name\":\"Alex\",\"rank\":\"Engineer\",\"crewID\":15,\"ship\":\"WebSphere Battleship\"}"));
196+
assertEquals(200, response.getStatus(), "output: " + response.readEntity(String.class));
197+
response = client.target(baseURL + "db/crew/it4").request().post(Entity.json("{\"name\":\"Nathan\",\"rank\":\"Captain\",\"crewID\":30,\"ship\":\"Jakarta Sailboat\"}"));
198+
assertEquals(200, response.getStatus(), "output: " + response.readEntity(String.class));
199+
200+
//Check findByShipSizeAndRank
201+
response = client.target(baseURL + "db/crew/shipSize/small/rank/Engineer").request().get();
202+
JsonReader reader = Json.createReader(new StringReader(response.readEntity(String.class)));
203+
JsonArray array = reader.readArray();
204+
JsonArray expectedArray = Json.createArrayBuilder().add(Json.createObjectBuilder().add("Name", "Mark").add("CrewID", 75).add("Ship", "Liberty Saucer").build()).build();
205+
assertEquals(expectedArray, array);
206+
207+
response = client.target(baseURL + "db/crew/shipSize/large/rank/Engineer").request().get();
208+
reader = Json.createReader(new StringReader(response.readEntity(String.class)));
209+
array = reader.readArray();
210+
expectedArray = Json.createArrayBuilder().add(Json.createObjectBuilder().add("Name", "Alex").add("CrewID", 15).add("Ship", "WebSphere Battleship").build()).build();
211+
assertEquals(expectedArray, array);
212+
213+
response = client.target(baseURL + "db/crew/shipSize/small/rank/Captain").request().get();
214+
reader = Json.createReader(new StringReader(response.readEntity(String.class)));
215+
array = reader.readArray();
216+
expectedArray = Json.createArrayBuilder().add(Json.createObjectBuilder().add("Name", "Jim").add("CrewID", 64).add("Ship", "Liberty Saucer").build())
217+
.add(Json.createObjectBuilder().add("Name", "Nathan").add("CrewID", 30).add("Ship", "Jakarta Sailboat").build()).build();
218+
assertEquals(expectedArray, array);
219+
}
220+
186221

187222
private static boolean isPostgresAvailable() {
188223
return checkHostAndPort("localhost", 5432);

0 commit comments

Comments
 (0)