Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our html minifier can't always handle the \ char #1587

Closed
steven1046 opened this issue Mar 26, 2020 · 5 comments
Closed

Our html minifier can't always handle the \ char #1587

steven1046 opened this issue Mar 26, 2020 · 5 comments
Assignees
@steven1046
Labels
bug Problems found in prod branch

Comments

@steven1046
Copy link
Member

Go to https://draft-guides.mybluemix.net/guides/reactive-messaging-sse.html#subscribing-to-server-sent-events and hover over EventSource and you can see it duplicate the line in the code that should be hotspotted:
image

This isn't due to there being two hotspots for the same thing because I removed one of them and it still happened.
@steven1046 steven1046 added the bug Problems found in prod branch label Mar 26, 2020
@gkwan-ibm
Copy link
Member

same issue in OpenLiberty/guide-microprofile-metrics#91

The UI cannot handle \ char correctly

@steven1046 steven1046 self-assigned this Mar 27, 2020
@steven1046
Copy link
Member Author

steven1046 commented Mar 27, 2020 •
edited
Loading

It looks like the minify_html: true option in config.yml is causing some source formatting to break in the code panel:
image

@steven1046
Copy link
Member Author

The escape character is already removed before any javascript runs so it's an issue with the minifying or something during build time.

@steven1046 steven1046 changed the title Some hotspots in draft guides are duplicating source code Our html minifier cannot handle the \ char always Apr 3, 2020
@steven1046
Copy link
Member Author

The root issue is that we use the octopress-minify-html gem which uses html_press under the covers which is deprecated and there have been some known issues (including the backslash escape char) but are no longer worked on due to being deprecated: stereobooster/html_press#21.

@steven1046 steven1046 changed the title Our html minifier cannot handle the \ char always Our html minifier can't always handle the \ char Apr 3, 2020
@steven1046
Copy link
Member Author

This will be fixed by #742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steven1046 steven1046

Labels
bug Problems found in prod branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steven1046 @k8vance88 @gkwan-ibm