Disable Jakarta EE9 features #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jingfu wang <[email protected]>
|
Update: the PR of this issue OpenLiberty/open-liberty#13165 has been merged, I check with Dave and that fix would be in next release (20.0.0.9) which is around end of August. |
|
Once you have delivered this PR, don't forget to update the couplet test list to include the new test case (couplet has its own test lists). See https://github.ibm.com/was-wdt-infrastructure/couplet-wdt-tests/tree/master/WDT/Liberty-Tools (just find the list that has the other feature test cases and add the new one). |
Signed-off-by: jingfu wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to disable Jakarta EE9 features.
We need all Jakarta EE9 features have direct dependency
com.ibm.websphere.appserver.eeCompatible-9.0so that we can use that as indicator to exclude all Jakarta EE9 features, but currently some Jakarta EE9 features still don't have direct dependencycom.ibm.websphere.appserver.eeCompatible-9.0. The runtime team is gonna add it to all Jakarta EE9 features under this issue OpenLiberty/open-liberty#13165, so disabling Jakarta EE9 features will be fully completed after this issue OpenLiberty/open-liberty#13165 is fixedGiven the above situation, currently we have two solutions:
com.ibm.websphere.appserver.eeCompatible-9.0as direct dependency to all Jakarta EE9 features then we can use this PR to permanently disable Jakarta EE9 features.com.ibm.websphere.appserver.eeCompatible-9.0as direct dependency to, then we use another PR to remove the hardcode once runtime team addscom.ibm.websphere.appserver.eeCompatible-9.0as direct dependency to all Jakarta EE9 featuresThe PR implements the solution 1 to ensure all test cases are passed, but we can update the PR to adopt solution 1 depends on how long runtime team can finish OpenLiberty/open-liberty#13165.
Fixes: #401
Signed-off-by: jingfu wang [email protected]