Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Jakarta EE9 features for Liberty Tools #401

Open
GeekArthur opened this issue Jul 27, 2020 · 0 comments
Open

Disable Jakarta EE9 features for Liberty Tools #401

GeekArthur opened this issue Jul 27, 2020 · 0 comments

Comments

@GeekArthur
Copy link
Contributor

GeekArthur commented Jul 27, 2020

Disable Jakarta EE9 features by not including them in the list of available features. This will ensure that they are not added to the server.xml as part of automatic feature detection and that if the user adds them manually they will be flagged as an unrecognized feature.

All features introduced for jakarta ee9 technologies have a direct dependency on feature com.ibm.websphere.appserver.eeCompatible-9.0

So all Jakarta EE9 features will have the following in the feature list:
<include symbolicName="com.ibm.websphere.appserver.eeCompatible-9.0"></include>

This issue will be fully completed after this issue OpenLiberty/open-liberty#13165 is fixed because currently some Jakarta EE9 features still don't have direct dependency com.ibm.websphere.appserver.eeCompatible-9.0 and runtime team is gonna add it to all Jakarta EE9 features.

New test cases will be needed for this feature:

  • Test cases to ensure that Jakarta EE9 features are not added to the server.xml when an application is deployed on the server that has missing features (e.g. application has a jsp but the jsp feature is not in the server.xml)
  • Test cases to ensure that the server configuration validator shows an error for Jakarta EE9 features in the server.xml

Useful links related with Jakarta EE9 features:

@GeekArthur GeekArthur self-assigned this Jul 27, 2020
@GeekArthur GeekArthur removed their assignment Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant