Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden detection of "is this a Liberty project?" calculation #492

Open
scottkurz opened this issue Feb 1, 2024 · 0 comments
Open

Broaden detection of "is this a Liberty project?" calculation #492

scottkurz opened this issue Feb 1, 2024 · 0 comments
Milestone

Comments

@scottkurz
Copy link
Member

Today in io.openliberty.tools.eclipse.Project.classifyAsServerModule() we look for one of the Liberty config files in src/main/liberty/config.

To align with the other two IDEs, we could do a more maximal detection heuristic of:

  • look for config files in src/main/liberty/config (which we already do)
  • look for liberty-plugin-config.xml files.
  • look for liberty-maven-plugin configured in project or imported parent project (and in LTV, for example, we are careful to look in profiles & pluginManagement even) - Maven-only obviously
@scottkurz scottkurz added this to the 24.0.6 milestone Feb 1, 2024
@scottkurz scottkurz modified the milestones: 24.0.6, 24.0.9 Apr 26, 2024
@awisniew90 awisniew90 modified the milestones: 24.0.9, 24.0.12 Sep 24, 2024
@awisniew90 awisniew90 modified the milestones: 24.0.12, 25.0.4 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants