Liberty Debug view elements don't get cleaned up after "Stop"

[scottkurz]

If I do "Debug" then a "Stop" (e.g. from Dashboard), and then "Debug" again, my Liberty Debug configs pile up and don't get cleaned up in the Debug view.

E.g.

[scottkurz]

Adding the observation that Eclipse seems to recognize at least our Debugger "session" is no longer running. We get different right-click ctx menu options for one of these not-cleaned-up elements:

compared to one where the JVM is active and the debugger is connected

[scottkurz]

I think somehow the debug launch is not completely terminating, some of the time.

Some times it does get cleaned up, in which case it looks like this (with the <terminated> string prefix in the view):

Not sure what the circumstances are for it working or not working. I've had it clean up successfully:

• doing a normal "Stop" after Debug
• after making a change that the debugger decides it can't do HCR upon, and choose to Terminate the JVM, the debug launch ends up looking like this:
• typing the <r> key in the terminal like in Restart (r) in dev mode kills the debugging session #498.

OTOH, when it doesn't work for whatever reason, the Debug view element never says <terminated> and it never goes away.

OTHER THOUGHTS

Might be mildly helpful for the view display to show the port, like the debugger child icon does, instead of just 'demo [Liberty]', for when the debugger underneath goes away. Not sure if we can change the view without renaming the launch itself, though, which we probably wouldn't want to do.