Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server.xml completion can include features with incompatible version numbers #275

Open
turkeylurkey opened this issue Mar 12, 2024 · 3 comments

Comments

@turkeylurkey
Copy link
Member

If I start typing a feature name and use completion the server will not suggest features which are not compatible with existing features. In this case we do not see other versions of jakartaee.
image
However if I do not start typing a feature name the server will give the full list of available features even ones incompatible with existing features. I would expect similar filtering to the previous example.
image
The problem becomes worse when I type ja because local filtering then displays the incompatible features.
image

@turkeylurkey
Copy link
Member Author

Related to #161

@cherylking
Copy link
Member

If I start typing a feature name and use completion the server will not suggest features which are not compatible with existing features.

@turkeylurkey This is not something that is enabled in the language server. I am not sure why you are only seeing those features, but we do nothing to detect incompatible features. There is an open issue for this functionality #70.

@cherylking
Copy link
Member

@turkeylurkey So the term "incompatible features" was misleading. What you are pointing out is that we do not display different versions of an already included feature when feature completion is used.

Your point is taken that the initial list of features that is displayed when no completion is done could do the same filtering. We will look into this at some point, but it will not be a priority at the moment.

@turkeylurkey turkeylurkey changed the title Server.xml completion can include incompatible features Server.xml completion can include features with incompatible version numbers Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants