Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize build for Liberty Tools for IntelliJ #175

Open
cherylking opened this issue May 8, 2023 · 0 comments
Open

Customize build for Liberty Tools for IntelliJ #175

cherylking opened this issue May 8, 2023 · 0 comments

Comments

@cherylking
Copy link
Member

cherylking commented May 8, 2023

Investigate whether we can/should provide a jar for Liberty Tools for IntelliJ to consume that includes the Eclipse LemMinX dependency. Currently, the dependency is configured with <scope>provided</scope> in the pom.xml in LCLS, which causes it to not be included in the ...-jar-with-dependencies.jar artifact. This is the desired behavior for both Liberty Tools for Eclipse (which includes Eclipse LemMinX within the Eclipse IDE) and Liberty Tools for Visual Studio Code (which includes Eclipse LemMinX as part of the XML Language Support by Red Hat extension.

Liberty Tools for IntelliJ currently has a direct dependency in its build.gradle for Eclipse LemMinX and this needs to be kept in sync with whichever version of LCLS it is pulling in. That dependency could be removed if Eclipse LemMinX was included in the LCLS artifact.

There are two jar files produced by the LCLS lemminx-liberty build today:

  1. liberty-langserver-lemminx-<version>.jar
  2. liberty-langserver-lemminx-<version>-jar-with-dependencies.jar

If we decide to fix this issue, we would add a third jar: liberty-langserver-lemminx-<version>-jar-with-all-dependencies.jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant