Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the MP Health and Kubernetes MP Health guides for MP Health Check 2.0 #289

Closed
pgunapal opened this issue Jun 6, 2019 · 12 comments
Closed

Comments

@pgunapal
Copy link
Member

pgunapal commented Jun 6, 2019

The following two guides should be updated to support MP Health Check 2.0 (mpHealth-2.0):
https://openliberty.io/guides/microprofile-health.html​
https://openliberty.io/guides/kubernetes-microprofile-health.html​

The MP Health Check 2.0 will introduce two new health check annotations and two new endpoints:

  • @ Liveness : /health/live
  • @ Readiness : /health/ready

For more information, please refer to the MpHealth-2.0 WAD, found in the Aha! feature:
https://ibm.ent.box.com/file/470499893181

@yeekangc
Copy link
Member

yeekangc commented Jun 28, 2019

Should align with 19.0.0.7. Also, update all relevant portions in other guides besides the direct Health Check ones too.

@gkwan-ibm
Copy link
Member

consider #224 and OpenLiberty/guide-microprofile-metrics#50

@gkwan-ibm
Copy link
Member

  • refactoring the app

@gkwan-ibm
Copy link
Member

  • working on the code change and readme

@gkwan-ibm
Copy link
Member

  • target to complete the draft update for both guides on this week

@evelinec
Copy link
Contributor

  • working on readme of the mphealth guide; application is converted

@gkwan-ibm
Copy link
Member

  • converting the app of kube health guide

@gkwan-ibm
Copy link
Member

  • completed the kube health guide
  • working on end-to-end testing on both guides

@gkwan-ibm
Copy link
Member

  • SME reviewed
  • completed the end-to-end test
  • may request an ID review

@justineechen
Copy link
Contributor

  • Justine verify QA site, end-to-end
  • Andrew will continue verifying the kube health

@gkwan-ibm
Copy link
Member

  • the mpHealth guide was published on last Fri
  • the kube health guide PR to qa is ready to review

@gkwan-ibm
Copy link
Member

the kube health guide was published on yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

7 participants