From 39eabd335a5822c8357071ffcedd4b1d1ed2f67a Mon Sep 17 00:00:00 2001 From: t27gupta <47546702+t27gupta@users.noreply.github.com> Date: Thu, 28 Jul 2022 10:44:06 -0400 Subject: [PATCH] updated contributions.md (#184) * updated contributions.md * updated contributions.md Co-authored-by: Gilbert Kwan --- CONTRIBUTING.md | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a3e0407d..c39bf203 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -2,7 +2,7 @@ Anyone can contribute to the Open Liberty guides and we welcome your contributions! -There are multiple ways to contribute: report bugs, fix bugs, contribute code, improve upon documentation, etc. +There are multiple ways to contribute: report bugs, fix bugs, contribute code, improve upon documentation, etc. ## Raising issues @@ -10,9 +10,9 @@ Please raise any bug reports in this [guide repository](../../issues). For new t A good bug report makes it easy for everyone to understand what you were trying to do and what went wrong. Provide as much context as possible so we can try to recreate the issue. -## Contributions +## Contributions -Contributing to an Open Liberty guide is simple. All you need to do is create your own branch to include your contribution and open a pull request to the `qa` (quality assurance) branch. +Contributing to an Open Liberty guide is simple. All you need to do is create your branch to include your contribution and open a pull request to the `staging` (quality assurance) branch. ### Text or content contributions @@ -20,39 +20,39 @@ If you are contributing text or content changes via a pull request, you need to Add a line to the end of the Git commit message to sign your work: -``` +```text Signed-off-by: Jane Williams ``` The sign-off is just a line at the end of the commit message that certifies that you wrote it or otherwise have the right to pass it on as an open source patch. -Use your real name when you sign. We can't accept pseudonyms or anonymous contributions. +Use your real name when you sign. We can't accept pseudonyms or anonymous contributions. Many Git UI tools have support for adding the `Signed-off-by` line to the end of your commit message. This line can be automatically added by the `git commit` command by using the `-s` option. -If reviewers agree with your change, your change will be merged to the `master` branch for publishing. +If reviewers agree with your change, your change will be merged to the `prod` branch for publishing. ### Code contributions If you are contributing trivial code changes such as typos, redundant spaces, or minor formatting and spelling errors, follow the instructions under [Text or content contributions](./CONTRIBUTING.md#text-or-content-contributions). -If you are contributing code changes via a pull request for non-trivial changes, you must sign off on the [Individual Contributor License Agreement](https://github.com/OpenLiberty/open-liberty/blob/master/cla/open-liberty-cla-individual.pdf). An example of a non-trivial change could be adding a new -microservice to the backend application of the guide. +If you are contributing code changes via a pull request for non-trivial changes, you must sign off on the [Individual Contributor License Agreement](https://github.com/OpenLiberty/open-liberty/blob/release/cla/open-liberty-cla-individual.pdf). An example of a non-trivial change could be adding a new +microservice to the backend application of the guide. -If you are contributing changes as part of your job, you may also wish to have your employer sign a [Corporate Contributor License Agreement](https://github.com/OpenLiberty/open-liberty/blob/master/cla/open-liberty-cla-corporate.pdf). +If you are contributing changes as part of your job, you may also wish to have your employer sign a [Corporate Contributor License Agreement](https://github.com/OpenLiberty/open-liberty/blob/release/cla/open-liberty-cla-corporate.pdf). -Instructions for how to sign and submit these agreements are located at the top of each document. +Instructions for how to sign and submit these agreements are located at the top of each document. -After we obtain the signed CLA, you are welcome to open a pull request against the `qa` branch, and the team will be notified for review. We ask you follow these steps through the submission process: +After we obtain the signed CLA, you are welcome to open a pull request against the `staging` branch, and the team will be notified for review. We ask you to follow these steps through the submission process: -1. Open a pull request against the `qa` branch. +1. Open a pull request against the `staging` branch. 2. A "CLA signed" label will be manually added by the team. -3. The team will be notified and will review your change(s). - - If there are further changes to be made, the team will request changes on the pull request. +3. The team will be notified and will review your change(s). + - If there are further changes to be made, the team will request changes on the pull request. - If the team does not agree with the change, the PR will be closed with an explanation and suggestion for follow-up. 4. If the team approves, a full Open Liberty site build will be run. 5. Based on the results of the build: - - If further review is needed, we will let you know about a pending review from our team and discuss any necessary improvements that need to be made to your change(s). + - If further review is needed, we will let you know about a pending review from our team and discuss any necessary improvements that need to be made to your change(s). - If everything is successful, the team will merge your PR. ## Questions and concerns