Skip to content

Commit 1172cbb

Browse files
authored
Add additional devc properties to metadata file (#427)
1 parent d5b02e9 commit 1172cbb

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5701,13 +5701,22 @@ public void writeDevcMetadata(boolean alive) {
57015701
metadataWriter.writeStartElement("devcModeMetaData");
57025702
writeElement(metadataWriter, "containerEngine", isDocker ? DEVC_CONTAINER_DOCKER : DEVC_CONTAINER_PODMAN);
57035703
writeElement(metadataWriter, "containerName", containerName != null ? containerName : DEVMODE_CONTAINER_BASE_NAME);
5704+
writeElement(metadataWriter, "imageName", imageName);
5705+
if (containerfile != null) {
5706+
writeElement(metadataWriter, "containerfile", containerfile.getCanonicalPath());
5707+
}
5708+
if (containerBuildContext != null) {
5709+
writeElement(metadataWriter, "containerBuildContext", containerBuildContext.getCanonicalPath());
5710+
}
57045711
writeElement(metadataWriter, "containerAlive", String.valueOf(alive));
5712+
writeElement(metadataWriter, "containerBuildTimeout", Integer.toString(containerBuildTimeout));
5713+
writeElement(metadataWriter, "containerRunOpts", containerRunOpts);
57055714
metadataWriter.writeEndElement();
57065715
metadataWriter.writeEndDocument();
57075716
metadataWriter.flush();
57085717
metadataWriter.close();
57095718
} catch (Exception e) {
5710-
warn("Failed to write metadata.");
5719+
warn("Failed to write metadata.\n" + e.getMessage());
57115720
}
57125721
}
57135722

src/test/java/io/openliberty/tools/common/plugins/util/DevUtilTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -539,10 +539,18 @@ public void testWriteDevcMetadataSimple() throws XMLStreamException, FactoryConf
539539
String content = FileUtils.readFileToString(metaDataXml, "UTF-8");
540540
assertTrue(content.contains("<containerName>liberty-dev</containerName"));
541541
assertTrue(content.contains("<containerAlive>true</containerAlive>"));
542+
assertTrue(content.contains("<containerBuildTimeout>600</containerBuildTimeout>"));
543+
assertTrue(content.contains("<containerEngine>docker</containerEngine>"));
544+
assertTrue(content.contains("<containerRunOpts></containerRunOpts>"));
545+
assertTrue(content.contains("<imageName></imageName>"));
542546

543547
util.writeDevcMetadata(false);
544548
content = FileUtils.readFileToString(metaDataXml, "UTF-8");
545549
assertTrue(content.contains("<containerName>liberty-dev</containerName"));
546550
assertTrue(content.contains("<containerAlive>false</containerAlive>"));
551+
assertTrue(content.contains("<containerBuildTimeout>600</containerBuildTimeout>"));
552+
assertTrue(content.contains("<containerEngine>docker</containerEngine>"));
553+
assertTrue(content.contains("<containerRunOpts></containerRunOpts>"));
554+
assertTrue(content.contains("<imageName></imageName>"));
547555
}
548556
}

0 commit comments

Comments
 (0)