Port wvlet/airframe#3941

Author: OndrejSpanel

airframe-surface/src/main/scala-3/org/opengrabeso/airframe/surface/CompileTimeSurfaceFactory.scala

@@ -568,14 +568,22 @@ private[surface] class CompileTimeSurfaceFactory[Q <: Quotes](using quotes: Q):
         // https://github.com/lampepfl/dotty-macro-examples/blob/aed51833db652f67741089721765ad5a349f7383/defaultParamsInference/src/macro.scala
         val defaultValue: Expr[Option[Any]] = field.defaultValueGetter match
           case Some(m) =>
-            val companion = Ref(t.typeSymbol.companionModule)
-            // Populate method type parameters with Any type
-            val dummyTypeList: List[TypeRepr] = m.paramSymss.flatten.map { tp => TypeRepr.of[Any] }.toList
-            val dv: Term                      = companion.select(m).appliedToTypes(dummyTypeList)
-            '{ Some(${ dv.asExprOf[Any] }) }
+            // Check if this is a case class in a trait, which can cause companion reference issues
+            val isInTrait = t.typeSymbol.owner.flags.is(Flags.Trait)
+            if isInTrait then
+              // Skip default values for case classes defined in traits to avoid erasure issues
+              '{ None }
+            else
+              val companion = Ref(t.typeSymbol.companionModule)
+              // Populate method type parameters with Any type
+              val dummyTypeList: List[TypeRepr] = m.paramSymss.flatten.map { tp => TypeRepr.of[Any] }.toList
+              val dv: Term                      = companion.select(m).appliedToTypes(dummyTypeList)
+              '{ Some(${ dv.asExprOf[Any] }) }
+
           case _ => '{ None }
 
         // Generate a field accessor { (x:Any) => x.asInstanceOf[A].(field name) }
+        /*
         val paramIsAccessible =
           t.typeSymbol.fieldMember(paramName) match
             case nt if nt == Symbol.noSymbol      => false
@@ -585,6 +593,7 @@ private[surface] class CompileTimeSurfaceFactory[Q <: Quotes](using quotes: Q):
             case m if m.privateWithin.nonEmpty    => false
             case _                                => true
         // println(s"${paramName} ${paramIsAccessible}")
+        */
 
         // Using StaticMethodParameter when supportin Scala.js in Scala 3.
         // TODO: Deprecate RuntimeMethodParameter

airframe-surface/src/test/scala/org/opengrabeso/airframe/surface/TraitInheritedClassTest.scala

@@ -0,0 +1,53 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.opengrabeso.airframe.surface
+
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should
+
+trait MT:
+  case class B(min: Int = 0, max: Int = 0)
+
+object MT extends MT
+
+/**
+ * Test and fix ported from https://github.com/wvlet/airframe/pull/3941
+ * */
+class TraitInheritedClassTest extends AnyFunSuite with should.Matchers {
+  test("reproduce the crash with trait-inherited case class") {
+    // This should not crash the compiler during the erasure phase
+    val schema = Surface.of[MT.B]
+    schema should not be null
+    schema.name shouldBe "B"
+    schema.fullName shouldBe "org.opengrabeso.airframe.surface.MT.B"
+    schema.params.length shouldBe 2
+    schema.params(0).name shouldBe "min"
+    schema.params(1).name shouldBe "max"
+  }
+
+  test("original issue scenario should work") {
+    // This reproduces the exact scenario from the issue
+    val schema = Surface.of[MT.B]
+
+    // Should be able to print the schema without crashing
+    val schemaString = schema.toString
+    schemaString.contains("B") shouldBe true
+
+    // Should have proper parameters with default values (though they may be None due to trait limitation)
+    schema.params.foreach { param =>
+      param.surface should not be null
+      param.surface.name shouldBe "Int"
+    }
+  }
+}

airframe-surface/src/test/scala/org/opengrabeso/airframe/surface/i3439.scala

@@ -31,6 +31,6 @@ class i3439 extends AnyFunSuite with should.Matchers {
   test("Handle inherited inner class") {
     //val mm = Surface.methodsOf[OuterType.type]
     val m = Surface.methodsOf[OuterType.InnerType]
-    //m.map(_.name) shouldContain "compare"
+    m.map(_.name) should contain ("compare")
   }
 }