Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bare asserts (in _run_gromacs) #36

Open
IAlibay opened this issue Sep 24, 2024 · 0 comments
Open

Avoid bare asserts (in _run_gromacs) #36

IAlibay opened this issue Sep 24, 2024 · 0 comments
Milestone

Comments

@IAlibay
Copy link
Member

IAlibay commented Sep 24, 2024

Bare asserts can be quite difficult for users to understand as they throw an assertion error with minimal user information.

Instead it would be better to check for file existance and throw an appropriate error type (IOError for files being missing maybe?) with a human readable error message.

@hannahbaumann hannahbaumann added this to the MVP milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants