Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build on 32-bit ARM #89

Open
jbeich opened this issue May 30, 2024 · 2 comments
Open

Fails to build on 32-bit ARM #89

jbeich opened this issue May 30, 2024 · 2 comments
Assignees
Labels

Comments

@jbeich
Copy link
Contributor

jbeich commented May 30, 2024

From error log:

In file included from Source/ScriptingEngine.cpp:24:
In file included from ./Source/Utils/dukglue/dukglue.h:3:
In file included from ./Source/Utils/dukglue/register_function.h:3:
In file included from ./Source/Utils/dukglue/detail_function.h:3:
In file included from ./Source/Utils/dukglue/detail_stack.h:6:
In file included from ./Source/Utils/dukglue/detail_types.h:160:
./Source/Utils/dukglue/detail_primitive_types.h:52:3: error: redefinition of 'DukType<long long>'
                DUKGLUE_SIMPLE_VALUE_TYPE(time_t, duk_is_number, duk_get_uint, duk_push_uint, value)
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./Source/Utils/dukglue/detail_primitive_types.h:17:10: note: expanded from macro 'DUKGLUE_SIMPLE_VALUE_TYPE'
                struct DukType<TYPE> { \
                       ^~~~~~~~~~~~~
./Source/Utils/dukglue/detail_primitive_types.h:46:3: note: previous definition is here
                DUKGLUE_SIMPLE_VALUE_TYPE(int64_t, duk_is_number, duk_get_number, duk_push_number, value) // have to cast to double
                ^
./Source/Utils/dukglue/detail_primitive_types.h:17:10: note: expanded from macro 'DUKGLUE_SIMPLE_VALUE_TYPE'
                struct DukType<TYPE> { \
                       ^
@segrax
Copy link
Member

segrax commented May 30, 2024

Thanks @jbeich ,

Looks like the DUKGLUE update last year added the line which is causing it to fail... Given we dont pass time_t objects into the scripting engine, its probably safe we remove it

134a8b5#diff-5eed5015760020806630d62aad20b9962fd03f95d1127a7b57d440a5bf1f4e08R52

Ive pushed a fix with the line commented out, but unable to test as I don't have arm

@segrax segrax added the bug label May 30, 2024
@segrax segrax self-assigned this May 30, 2024
@jbeich
Copy link
Contributor Author

jbeich commented Jun 1, 2024

Applied downstream but it may take ~1 month to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants