Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't link wpcap.lib when using SOEM with cmake fetch_content #785

Open
limymy opened this issue Feb 6, 2024 · 3 comments · May be fixed by #786
Open

Can't link wpcap.lib when using SOEM with cmake fetch_content #785

limymy opened this issue Feb 6, 2024 · 3 comments · May be fixed by #786

Comments

@limymy
Copy link

limymy commented Feb 6, 2024 •
edited
Loading

MSVC is unable to link wpcap.lib when using this repository as a sub-project via the CMake fetch_content module. The error message is as follows:

[build] LINK : fatal error LNK1104: 无法打开文件“wpcap.lib” [E:\mycode\soem_test\build\cpp_test.vcxproj]

This issue may be related to the following lines in the CMakeLists.txt file:

SOEM/CMakeLists.txt

Lines 25 to 30 in 1817b8b

include_directories(oshw/win32/wpcap/Include)
if(CMAKE_SIZEOF_VOID_P EQUAL 8)
link_directories(${CMAKE_CURRENT_LIST_DIR}/oshw/win32/wpcap/Lib/x64)
elseif(CMAKE_SIZEOF_VOID_P EQUAL 4)
link_directories(${CMAKE_CURRENT_LIST_DIR}/oshw/win32/wpcap/Lib)
endif()

It appears that the directory is not being passed to the parent project.
@limymy limymy linked a pull request Feb 6, 2024 that will close this issue
Open
@limymy
Copy link
Author

limymy commented Feb 6, 2024

I have submitted a pull request to solve this problem. #786

@kj4tmp
Copy link

kj4tmp commented Apr 29, 2024

i believe I am hitting this same issue as part of my project that attempt to use include_subdirectory and target_link_libraries with SOEM

https://github.com/kj4tmp/pyecm

Building Custom Rule D:/a/pyecm/pyecm/CMakeLists.txt
      soem_ext.cpp
    D:\a\pyecm\pyecm\ext\SOEM\oshw\win32\nicdrv.h(21,10): error C1083: Cannot open include file: 'pcap.h': No such file or directory [D:\a\pyecm\pyecm\build\cp310-cp310-win32\soem_ext.vcxproj]
      (compiling source file '../../pyecm/soem_ext.cpp')

@kj4tmp
Copy link

kj4tmp commented Apr 29, 2024

I was able to implement the following workaround by adding the following to my CMakeLists.txt

if(WIN32)
  # Add the directory containing pcap.h to the include directories
  # this is a hack to temporarily fix https://github.com/OpenEtherCATsociety/SOEM/issues/785
  target_include_directories(soem_ext PUBLIC
    ${CMAKE_CURRENT_LIST_DIR}/ext/SOEM/oshw/win32/wpcap/Include
  )
  if(CMAKE_SIZEOF_VOID_P EQUAL 8)
    target_link_directories(soem_ext PUBLIC ${CMAKE_CURRENT_LIST_DIR}/ext/SOEM/oshw/win32/wpcap/Lib/x64)
  elseif(CMAKE_SIZEOF_VOID_P EQUAL 4)
    target_link_directories(soem_ext PUBLIC ${CMAKE_CURRENT_LIST_DIR}/ext/SOEM/oshw/win32/wpcap/Lib)
  endif()
  
endif()

SOEM is a git submodule at ./ext/SOEM/ in my project

WARNING: I am not a cmake expert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix link directory error when using SOEM with cmake fetch_content limymy/SOEM
2 participants
@kj4tmp @limymy