Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tested And Removed Commented Code #1401

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Tested And Removed Commented Code #1401

wants to merge 2 commits into from

Conversation

danielshid
Copy link
Contributor

Description

I tested commented code in RadarChartComponent regarding cases where there is no data to display. To test the code I used invalid date ranges on both groups and meters. I came to the conclusion that it was safe to remove the commented code.

Fixes #1395

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove check for readings unavailable
1 participant
@danielshid