Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules are not kept up to date #12

Open
wixoaGit opened this issue Oct 14, 2023 · 3 comments
Open

Submodules are not kept up to date #12

wixoaGit opened this issue Oct 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@wixoaGit
Copy link
Member

Just had to manually run git submodule update --init --recursive on OpenDream

@wixoaGit wixoaGit added the bug Something isn't working label Oct 14, 2023
@Crossedfall
Copy link
Collaborator

Crossedfall commented Oct 14, 2023

This should be handled by this block. Will need to see why it's not properly updating things

def updateSubmodules(od_repo: Repo) -> None:
"""
Recursively update and initialize submodules
od_repo: OpenDream repository with the submodules
"""
for submodule in od_repo.submodules:
submodule.update(init=True, recursive=True)
compile_logger.info(f"{submodule.name} is at: {submodule.hexsha}")

@Crossedfall
Copy link
Collaborator

Haven't been able to reproduce this. My local instance has been updating the submodules without much issue. Going to keep an eye out for the next submodule bump to see if we encounter the same issue again. Closing for now.

@Crossedfall Crossedfall closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2023
@Crossedfall
Copy link
Collaborator

I may have reproduced this. Re-opening

@Crossedfall Crossedfall reopened this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants