Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird } at end of line causing parse failure #1826

Open
ZeWaka opened this issue Jun 2, 2024 · 1 comment
Open

weird } at end of line causing parse failure #1826

ZeWaka opened this issue Jun 2, 2024 · 1 comment
Labels
bug Something isn't working Codebase: Goonstation Relating to the Goonstation codebase Compiler Involves the OpenDream compiler

Comments

@ZeWaka
Copy link
Collaborator

ZeWaka commented Jun 2, 2024

it can't handle this:

/typeinfo/obj/machinery/conveyor_switch {
    mats = list("metal" = 10,
                "conductive" = 10,
                "crystal" = 10)}

/obj/machinery/conveyor_switch

but it can handle this with the extra newline:

/typeinfo/obj/machinery/conveyor_switch {
    mats = list("metal" = 10,
                "conductive" = 10,
                "crystal" = 10)
}

/obj/machinery/conveyor_switch

the original preproc dump:

/obj/machinery/conveyor_switch/typeinfo_type = /typeinfo/obj/machinery/conveyor_switch; /obj/machinery/conveyor_switch/get_typeinfo() { ; return get_singleton(src.typeinfo_type); } /typeinfo/obj/machinery/conveyor_switch; /typeinfo/obj/machinery/conveyor_switch/New(){ . = ..(); admin_procs += list(/obj/machinery/conveyor_switch/proc/trigger); }
/obj/machinery/conveyor_switch/typeinfo_type = /typeinfo/obj/machinery/conveyor_switch; /obj/machinery/conveyor_switch/get_typeinfo() { ; return get_singleton(src.typeinfo_type); } /typeinfo/obj/machinery/conveyor_switch {
    mats = list("metal" = 10,
                "conductive" = 10,
                "crystal" = 10)}
/obj/machinery/conveyor_switch
    name = "conveyor switch"
    desc = "A conveyor control switch."

perhaps related to #512

@ZeWaka ZeWaka changed the title weird } at end of line causing error recovery weird } at end of line causing parse failure Jun 2, 2024
@ZeWaka ZeWaka added Compiler Involves the OpenDream compiler Codebase: Goonstation Relating to the Goonstation codebase labels Jun 2, 2024
@ZeWaka
Copy link
Collaborator Author

ZeWaka commented Jun 2, 2024

fixed on goon since it was uglycode anyways

@ZeWaka ZeWaka added the bug Something isn't working label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Codebase: Goonstation Relating to the Goonstation codebase Compiler Involves the OpenDream compiler
Projects
None yet
Development

No branches or pull requests

1 participant