Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loop behaviour in animate() #1801

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix loop behaviour in animate() #1801

wants to merge 10 commits into from

Conversation

amylizzle
Copy link
Contributor

@amylizzle amylizzle commented May 20, 2024 •
edited
Loading

Loop now properly works for chained animations.

Note that animate()s arg processing is still fucked so it only works if you pass it as a named arg, not a positional one.

Fixes #1791

@boring-cyborg boring-cyborg bot added the Client Involves the OpenDream client label May 20, 2024
amylizzle
amylizzle commented May 23, 2024
View reviewed changes
OpenDreamClient/Rendering/DreamIcon.cs Outdated Show resolved Hide resolved
OpenDreamClient/Rendering/DreamIcon.cs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client Involves the OpenDream client size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

animate(loops=n) doesn't work when animations are chained
1 participant
@amylizzle