Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

优化代码实现 #378

Open
zhugelianglongming opened this issue Nov 16, 2022 · 0 comments · Fixed by #392
Open

优化代码实现 #378

zhugelianglongming opened this issue Nov 16, 2022 · 0 comments · Fixed by #392

Comments

@zhugelianglongming
Copy link
Collaborator

zhugelianglongming commented Nov 16, 2022 •
edited
Loading

优化内容

  1. 规范化 Receiver 命名
  2. 抽取重复代码
  3. 抽取函数，避免函数实现过长
  4. 面向过程编程实现 -> 面向对象编程实现
  5. 提高代码可读性
  6. 移除冗余文件、冗余代码
  7. ...

优化路径

优先从 kernel/engines/xuperos/xtoken 向上扩大覆盖，目前由于历史代码的兼容问题，golangci-lint限定在指定目录下工作，待相关问题修复后，逐渐覆盖所有代码文件。

相关管理见：Xupercore code quality improvement project
@zhugelianglongming zhugelianglongming mentioned this issue Dec 2, 2022
Merged
zhugelianglongming added a commit to zhugelianglongming/xupercore that referenced this issue Dec 20, 2022
@zhugelianglongming
Refine readability OpenAtomFoundation#378
99b0acd
zhugelianglongming added a commit to zhugelianglongming/xupercore that referenced this issue Dec 23, 2022
@zhugelianglongming
Refine readability OpenAtomFoundation#378
9e101d7
This was referenced Dec 23, 2022
Merged
Open
zhugelianglongming added a commit to zhugelianglongming/xupercore that referenced this issue Jan 9, 2023
@zhugelianglongming
Refine readability OpenAtomFoundation#378
916e92e
zhugelianglongming added a commit that referenced this issue Jan 10, 2023
@zhugelianglongming
Refine readability #378 (#394)
ff7f791
zhugelianglongming added a commit to zhugelianglongming/xupercore that referenced this issue Jan 10, 2023
@zhugelianglongming
Refine readability OpenAtomFoundation#378 (OpenAtomFoundation#394)
0da8d22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize judge for address (fix#378) zhugelianglongming/xupercore
1 participant
@zhugelianglongming