Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Incorrect break when list all docker container #44

Open
ABNER-1 opened this issue Mar 7, 2023 · 0 comments · May be fixed by #45
Open

[BUG] Incorrect break when list all docker container #44

ABNER-1 opened this issue Mar 7, 2023 · 0 comments · May be fixed by #45

Comments

@ABNER-1
Copy link

ABNER-1 commented Mar 7, 2023

As code show, this function will get all container status when container in dockerComposeServices.
However, when get any correct container, the function will break incorrectly.
This bug make the function return only the first correct container.

https://github.com/SmartIDE/SmartIDE/blob/fb52a51870f8d65561651075caaa345bef038dd0/cli/cmd/start/env.go#L132-L141
ABNER-1 pushed a commit to ABNER-1/SmartIDE that referenced this issue Mar 7, 2023
@ABNER-1
fix OpenAtomFoundation#44 bug
4769b57 
Signed-off-by: Abner-1 <[email protected]>
@ABNER-1 ABNER-1 linked a pull request Mar 7, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #44 "Get only first container and cause smartide start failed" ABNER-1/SmartIDE
1 participant
@ABNER-1