Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Glitchtip broken #897

Open
abrichr opened this issue Oct 28, 2024 · 3 comments
Open

[Bug]: Glitchtip broken #897

abrichr opened this issue Oct 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@abrichr
Copy link
Member

abrichr commented Oct 28, 2024

Describe the bug

image

To Reproduce

https://app.glitchtip.com/openadaptai/settings/projects/openadapt

@abrichr abrichr added the bug Something isn't working label Oct 28, 2024
@abrichr
Copy link
Member Author

abrichr commented Oct 28, 2024

image

@abrichr
Copy link
Member Author

abrichr commented Oct 28, 2024

From @0dm on Discord:

ok so removing the @logger.catch in replay(...) lets the error reporter do its thing, but i get an error related to QT because of the before_send_event function. removing it allows sentry to work

@abrichr
Copy link
Member Author

abrichr commented Nov 1, 2024

@0dm:

needs to be configured to only report issues instead of performance metrics

e.g.

def configure_error_reporting() -> None:
...
    if is_reporting_branch:
        sentry_sdk.init(
            dsn=config.ERROR_REPORTING_DSN,
            # Disable performance events
            # TODO: make configurable
            traces_sample_rate=0.0,
            before_send=before_send_event,
            ignore_errors=[KeyboardInterrupt],
        )

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant