Skip to content

Issue related to minItems/maxItems resulting in changes being detected #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
s-jepsen opened this issue May 21, 2025 · 2 comments
Closed
Assignees

Comments

@s-jepsen
Copy link

Since openapi-diff version 2.1.0, there's an issue related to minItems/maxItems.

Whenever maxItems property is set in a requestBody - the diff plugin flags it as change.

Resulting in:

==========================================================================
==                            API CHANGE LOG                            ==
==========================================================================
                                core-asset                                
--------------------------------------------------------------------------
--                            What's Changed                            --
--------------------------------------------------------------------------
- PUT    /v3/core-asset/organizations/{organization_id}/assets/move
  Request:
        - Changed application/json
          Schema: Backward compatible
--------------------------------------------------------------------------
--                                Result                                --
--------------------------------------------------------------------------
                   API changes are backward compatible                    
--------------------------------------------------------------------------

The problem is located in move-core-assets-request.yml#maxItems

I've added a Maven project for reproducing the issue - it might be related to change:
#753

openapi-diff-test.zip

@DrSatyr
Copy link
Collaborator

DrSatyr commented May 21, 2025

@s-jepsen issue introduced in #753 was fixed by #785. There is no new release since fix. Can you please check if it reproduced from the main branch?

@s-jepsen
Copy link
Author

I can verify the fix resolves the above issue.

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants