Skip to content

Unused requirements + missing requirement in pyproject.toml #217

@guzmud

Description

@guzmud

Description

The requirements described in pyproject.toml do not match the requirements used by the pyoaev codebase. A couple ones are unused while one seems to be a transient requirement (used but undeclared, potentially obtained through a different requirement).

Environment

  1. pyoaev version: release/current

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Run deptry . for a quick overview (though inaccurate)
  2. git grep prometheus or git grep opentelemetry

Expected Output

pyproject.toml describes the required packages, all of them and only them

Actual Output

Unused requirements (probably copy-pasted from pycti) and missing requirements.

Additional information

Thanks to @throuxel for suggesting the tool deptry for a quick overview of the situation. Below a screenshot of a first run (vanilla configuration) with a few comments.

Image
  • in vanilla configuration, deptry looks for the dev and doc dependencies found in the pyproject.toml inside the Python codebase (while a quick git grep points out their use, e.g. in the pre-commit)
  • unsure about the lack of test dependencies in the pyproject.toml (hence the mention of pytest)

Metadata

Metadata

Assignees

No one assigned

    Labels

    buguse for describing something not working as expectedneeds triageuse to identify issue needing triage from Filigran Product team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions