I don't think removing the fix is beneficial as long as it solves a problem.
I agree, we could add a toggle via ENV or config and not rely on a game specific fix. At the moment though, we don't really do engine or launcher-wide patches. Maybe we should.

There's more context available in #94 (comment) and #94 (comment) too.

I personally think we should remove it completely if we aren't going to use it. But fine by me if you want to keep it as an option/env. var. The area I want to attack is the default settings, which currently apply to an AC game and to Rainbow Six Siege.

I think we should just keep the current fixes for now that disable the uplay overlay, but be strict about allowing future fixes that disable them as we know it can potentially break core in-game functionality.

What problems are you observing in the game play with AC and Rainbow Six specifically in the context of disabling uplay overlay?

I'm not having any problems whatsoever. I only have R6 Siege of those two games, but it's unplayable due to no anti-cheat support.

I believe that the current fixes are outdated and should be removed. Many improvements have been done to Proton since those fixes were added, so the overlay probably works fine.

It's what I said in my issue: if it's problematic in one, it's problematic in all; if it's not problematic in any, then the fix is unnecessary.

Regarding R6 Siege, they have removed their native Vulkan support.
The AC fix is outdated because it feels odd to have it for this specific AC game but not for other ACs and/or Ubisoft games.

As I see it, we should not dictate default settings for the overlay for the user (same logic for other digital stores). It may or may not cause problems for the user. If it causes, the user may choose to disable it, but not Proton-GE.

The way I see such fixes, it seems to me something like "a lot of users complain about overlay in this game here, so let's add a fix for it", but again, the overlay is exactly the same for all games. It's either problematic or not problematic for all of them.

As I see it, the less "destructive" option is to not have UPlay fixes at all, rather than disabling UPlay overlay for every game.

I would suggest to keep the fixes for now and add an option to the config file, if we merge #152 and document it in #122 / #124 together with other options.

If the overlay doesn't cause problems in todays Proton, we shouldn't set defaults. Fair enough.
But if it does, we should consider detecting Uplay (it will never be Ubisoft Connect for me) and disable it for all games.

Since you only own 1/2 of them and cannot observe any problems with the game that this fix introduces, then I'm not seeing what this change gains for us besides the risk of severely degrading the performance for the user.

I believe that the current fixes are outdated and should be removed. Many improvements have been done to Proton since those fixes were added, so the overlay probably works fine.

In the context of this change, the only thing that matters is how the uplay overlay affects the gaming experience for the user when playing these specific titles. Not with how you feel, believe or suspect that will probably work fine. And if we're to trust the user ProtonDB reports, then this change will just hurt the UX as future users would have to disable the overlay manually. Unless you're able to demonstrate or provide evidence with logs/upstream issue/commit of how disabling it is detrimental or is now obsolete, I won't accept this change.