-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pydantic>2 #83
pydantic>2 #83
Conversation
@christophreimer @ValentinaHutter we are using this version for out InterTwin use case, since it is necessary to have Pydantic > 2 in combination with HydroMT. What do you think it would be the best approach to move towards? I know you have many other components relying on Pydantic 1.x, but we would like to find a way to publish the version based on Pydantic 2 somehow. |
Please make sure all tests are running successfully, otherwise we cannot merge the PR. We will then review it and create a new release. Then we can start updating our internal repositories to go from pydantic<2 to pydantic>2. |
@ValentinaHutter yes, there is one test failing, related to an old process graph from UC8 containing two experimental processes: Here is the link to visualize the process graph used there: Question: should we remove that process graph and update it with the latest used in UC8? Using that one the tests are passing. Let me know if you are still using the |
Thanks for pointing this out! We replaced the For the tests, it should be fine to replace I will create a PR in our processes-spec to remove |
…networkx into pydantic2
@ValentinaHutter tests are passing, I replaced the process graph with the latest version used for UC8. |
Tests are passing, except one!