Wait till path available #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmileSonneveld
commented
Oct 23, 2024
tests/conftest.py
Outdated
| @@ -179,6 +182,36 @@ def _setup_local_spark(out: TerminalReporter, verbosity=0): | |||
| def api_version(request): | |||
| return request.param | |||
|
|
|||
| # TODO: Deduplicate code with openeo-python-driver | |||
There was a problem hiding this comment.
@soxofaan Is there an easy way to share test helpers? It is not very common to make test code available from other repositories as far as i know
There was a problem hiding this comment.
that _Sleeper implementation actually comes from python client I think. There I started putting testing utilities under the openeo.testing namespace: https://github.com/Open-EO/openeo-python-client/tree/master/openeo/testing
We also have that with python driver with openeo_driver.testing: https://github.com/Open-EO/openeo-python-driver/blob/master/openeo_driver/testing.py
There was a problem hiding this comment.
soxofaan
reviewed
Oct 23, 2024
soxofaan
reviewed
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open-EO/openeo-geotrellis-extensions#329