Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: token registry mint method doesn't throw error when address provided is not a token registry #86

Open
justussoh opened this issue Aug 27, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@justussoh
Copy link
Contributor

The expected behavior is for cli to detect that there's no smart contract at that address.

@justussoh justussoh added the bug Something isn't working label Aug 27, 2020
@Nebulis Nebulis added enhancement New feature or request and removed bug Something isn't working labels Aug 27, 2020
@Nebulis
Copy link
Contributor

Nebulis commented Aug 27, 2020

Input example ? Current output ?

It should be done on more functions than the mint

@justussoh
Copy link
Contributor Author

justussoh commented Aug 27, 2020

Input example:
open-attestation token-registry mint --tokenId 0x89f533e51c8c01f6dacad58f20087fc77e27b39a32caea60039a9355b4aba256 --address 0x67b5Bc373cAA527Cee654d6A0f629ba1E84fAd02 <this address does not have a smart contract> --to 0x87CB17B6d1745389d27c2fdC49560E74E126E2B9 -k <removed private key> -network ropsten

--address flag is for the address of the token registry

Problem:
Does not throw an error when invalid address is input

@Nebulis
Copy link
Contributor

Nebulis commented Aug 27, 2020

Could you investigate on which more functions this needs to be done ? for instance there is document store issue/revoke too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants