Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet Connectivity Required #306

Open
skydudie opened this issue Apr 11, 2024 · 0 comments
Open

Internet Connectivity Required #306

skydudie opened this issue Apr 11, 2024 · 0 comments

Comments

@skydudie
Copy link

Hello,

Not sure if this was the intended behaviour, but after merging #244 the wrap and sign commands no longer work on a machine that is not internet enabled.

When wrapping the package checks for an updated version but if the request fails, the failure is not handled and instead throws the error below without completing the operation.
image

We've managed to override the update check by putting a huge number for the nextUpdateMessageDisplayTimestamp within the oacli-config.json file.

Perhaps it might be better to have a flag to enable/disable the middleware that does the update check, or at least handle the failure so that the wrapping/signing can still occur.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant