Skip to content

Dual hints should not hint locations in precompleted dungeons #2242

@Level80Starmie

Description

@Level80Starmie

This issue was previously worked for Sometimes hints in pulls #2085 and #2097 but doesn't seem to account for dual hints. Tested the same way Fenhl did in the testing for 2097, I've updated the plando to precomplete all 8 dungeons and removed all the OW duals, we still get dual hints. The function starting at 954 in Hints.py looks to be doing the check if the location is precompleted, not sure if dual hints containing two locations rather than one might be causing some issue.

precompleted-dual-test.json
OoT_C57A7_XPTFS1AC93_Spoiler.json

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: Hintsrelated to how we help the playerType: BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions