Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: RemoveExternalUserId/SetExternalUserId no answer #341

Open
3 tasks done
twelve-cgn opened this issue Nov 18, 2022 · 5 comments
Open
3 tasks done

[Bug]: RemoveExternalUserId/SetExternalUserId no answer #341

twelve-cgn opened this issue Nov 18, 2022 · 5 comments

Comments

@twelve-cgn
Copy link

twelve-cgn commented Nov 18, 2022

What happened?

I am currently trying to upgrade from 3.10.6 to 4.1.3.
So far we have always called:

Com.OneSignal.OneSignal.Current.SetExternalUserId(Application.User.PushUserId);
Com.OneSignal.OneSignal.Current.DeleteTags(new List<string>() { "pushuserid", "Database", "Version"});
Com.OneSignal.OneSignal.Current.SendTags(new Dictionary<string, string>()
                  {
                      { "pushuserid", Application.User.PushUserId },
                      { "Database", Application.User.Database },
                      { "License", Application.User.Licensename },
                      { "Version", Xamarin.Essentials.AppInfo.VersionString }
                  });

We have never used a RemoveExternalUserId before.

If I now simply call a SetExternalUserId, I no longer get a response if another userid was previously set. With RemoveExternalUserId I get no response if no UserId was set so far.

removed = await OneSignalSDK.Xamarin.OneSignal.Default.RemoveExternalUserId();
set = await OneSignalSDK.Xamarin.OneSignal.Default.SetExternalUserId(Application.User.PushUserId);

I have already adjusted the handling of the tags, so that only changed/added tags are set. But also here the SendTags does not work, but I have to send each tag individually by SendTag.

I really despair. So far, the connection never made problems, but with the 4 version really nothing works.

Is there perhaps a simple example application, with the current target versions (Android API 31 / iOS 15.4+)

Steps to reproduce?

Install 4.1.3

What did you expect to happen?

That it works like the old version

OneSignal Xamarin SDK version

4.1.3

Which platform(s) are affected?

  • iOS
  • Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@robfrancis
Copy link

robfrancis commented Apr 12, 2023

Are you still having this issue?
Did you find a work around?

I am also seeing this issue.

var result = await OneSignal.Default.RemoveExternalUserId();

Appears to never return a result if the ExternalUserId does not exist/has previously been removed.
Using version 4.3.4

@emawby
Copy link
Contributor

emawby commented Apr 12, 2023

@robfrancis Thank you for reporting are you also not receiving a response if you set a second setExternalUserId? We will investigate and work on a fix for both problems

@robfrancis
Copy link

robfrancis commented Apr 14, 2023

@robfrancis Thank you for reporting are you also not receiving a response if you set a second setExternalUserId? We will investigate and work on a fix for both problems

I have found this issue only affect Android.

Provided an ExternalUserId exists prior to this next segment of code

var result = await OneSignal.Default.RemoveExternalUserId();
Debug.WriteLine($"RemoveExternalUserId() 1 - {result}");

var result2 = await OneSignal.Default.RemoveExternalUserId();
Debug.WriteLine($"RemoveExternalUserId() 2 - {result2}");

result returns correctly.
result2 never returns and hangs on this line. The debug line below it does not execute and no exception is thrown.

@robfrancis
Copy link

@emawby

Any update on this?

@Cvijo
Copy link

Cvijo commented Sep 20, 2023

Same problem in my case too. SetExternalUserId hangs application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants