Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework Laptop 13 120Hz screen not correctly handled #6

Closed
RikPi opened this issue Dec 31, 2024 · 11 comments
Closed

Framework Laptop 13 120Hz screen not correctly handled #6

RikPi opened this issue Dec 31, 2024 · 11 comments

Comments

@RikPi
Copy link
Contributor

RikPi commented Dec 31, 2024

Hi,
I have the 120Hz screen on my FW 13 and the application shows 3 possibilities for the refresh rate: "Auto", "60Hz" and "165Hz". I believe that this is what it should show for a FW 16. Also, the "165Hz" button does nothing on my laptop.

Proposed solution

Add a laptop model check when the app builds the UI and dynamically set button text and click event functions to the compatible options.

Thank you for your great work and happy new year! :)

@Oganoth
Copy link
Owner

Oganoth commented Dec 31, 2024

Ho that's intresting, i'll push some changes in 5 mins can you try again after?

@Oganoth
Copy link
Owner

Oganoth commented Dec 31, 2024

the changes are live, the integration is basic atm but tell me if it work and send me your log in the logs folder 👍

@Oganoth
Copy link
Owner

Oganoth commented Dec 31, 2024

did a other commit, try it out :)

@RikPi
Copy link
Contributor Author

RikPi commented Dec 31, 2024

It works and sets the refresh rate correctly to 120Hz!
However, the button text string is still missing:
image

And I noticed that the iGPU temperature is not logged and stays at 0.0°C

2024-12-31_1.log

Thanks! :)

@Oganoth
Copy link
Owner

Oganoth commented Dec 31, 2024

did a other update, try it and send me your logs and your file sensors.json too please 🙏

@RikPi
Copy link
Contributor Author

RikPi commented Dec 31, 2024

2024-12-31_2.log
sensors.json
Here you go! :)
(120Hz string is fixed)

@Oganoth
Copy link
Owner

Oganoth commented Dec 31, 2024

Thanks you, I look at the sensor id problem and I will tell you when i push a fix

@Oganoth
Copy link
Owner

Oganoth commented Dec 31, 2024

Updated, can you try and again send me the files? Thanks for your help !

@RikPi
Copy link
Contributor Author

RikPi commented Dec 31, 2024

Hi! Here they are:
2024-12-31_3.log
sensors.json
iGPU temp is still at 0.0 and I also noticed that the brightness slider is set at 100% when the application starts (even if the real brightness level is different from the Windows slider) and does not change as the Windows slider changes. If used, the Hub slider works as expected, though :)

@Oganoth
Copy link
Owner

Oganoth commented Dec 31, 2024

Updated, tell me if it works :)

@RikPi
Copy link
Contributor Author

RikPi commented Jan 7, 2025

Hi! Sorry for the long delay. I took some holidays from my laptop :)
Now the slider of the hub correctly sets the brightness but it does not update when the system slider is changed, the iGPU temp works!

Additionally, there are a bunch of warnings (that seem to be originating from incorrect PowerShell command parameters) and some other errors on setting power plans, I'll attach the usual files :)

framework_cc.log
sensors.json

Finally, just a small quality of life request: When the hub is started it defaults the refresh rate to "Auto". I usually keep my FW at 120Hz and this defaults it at 60Hz, requiring me to change it back. Do you think it would be a nice change if the hub defaults to the current refresh rate? This avoids a temporary black screen and some apps to stop working in case the refresh rate is different.

Thank you, as always!

@Oganoth Oganoth closed this as completed Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants