Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displayDialogAsync is crashing after around 15 seconds after successfully opening an URL #5211

Closed
pietrofxq opened this issue Dec 19, 2024 · 9 comments
Assignees
Labels
Area: Outlook Issue related to Outlook add-ins Needs: author feedback Waiting for author (creator) of Issue to provide more info Status: in backlog Issue is being tracked in the backlog but timeline for resolution is unknown Status: no recent activity Issue or PR is stale (no recent activity)

Comments

@pietrofxq
Copy link

Provide required information needed to triage your issue

Your Environment

  • Platform [PC desktop, Mac, iOS, Office on the web]: PC
  • Host [Excel, Word, PowerPoint, etc.]: Outlook
  • Office version number: Web
  • Operating System: Windows 11
  • Browser (if using Office on the web): Chrome

Expected behavior

Iframe popup should stay open and not crash

Current behavior

When I open my service URL with displayDialogAsync using these parameters:

{
          height: 90,
          width: 90,
          promptBeforeOpen: false,
          displayInIframe: true,
 },

the URL is loaded correctly. After doing no action and waiting 15 seconds, this screen shows up:

image

Clearing network and console in devtools and waiting for the crash reports no activity whatsoever about what might have happened

Steps to reproduce

Call displayDialogAsync with these parameters:

 Office.context.ui.displayDialogAsync(
          'https://fire.chilipiper.io',
          {
            height: 90,
            width: 90,
            promptBeforeOpen: false,
            displayInIframe: true,
          })
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP label Dec 19, 2024
@exextoc exextoc added Needs: attention 👋 Waiting on Microsoft to provide feedback Area: Outlook Issue related to Outlook add-ins and removed Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP labels Dec 19, 2024
@exextoc exextoc self-assigned this Dec 19, 2024
@Oleg-O
Copy link
Collaborator

Oleg-O commented Dec 19, 2024

Could you please provide the version of this Outlook client?

@Oleg-O Oleg-O added Needs: author feedback Waiting for author (creator) of Issue to provide more info and removed Needs: attention 👋 Waiting on Microsoft to provide feedback labels Dec 19, 2024
@pietrofxq
Copy link
Author

Could you please provide the version of this Outlook client?

I am testing in outlook web, do I need to reproduce it on desktop?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: attention 👋 Waiting on Microsoft to provide feedback and removed Needs: author feedback Waiting for author (creator) of Issue to provide more info labels Dec 20, 2024
@pietrofxq
Copy link
Author

is there anything else I can add to help with this? It is currently blocking a major feature of our add-in that we would like to release. It would be helpful to get a better error message from that crash, we don't know where to start investigating it.

@sivachandran-msft
Copy link

Hi @pietrofxq , thanks for reporting & sharing the required details to repro this issue. We could repro this in our environment. We have added this work item to our backlog. However, at this time, we do not have an estimated timeline for when a fix will be implemented. We appreciate your patience and understanding as we work towards a resolution.

Internal TrackingID: 5188722

@sivachandran-msft sivachandran-msft added Status: in backlog Issue is being tracked in the backlog but timeline for resolution is unknown and removed Needs: attention 👋 Waiting on Microsoft to provide feedback labels Jan 15, 2025
@anjalitp
Copy link
Collaborator

@pietrofxq Could you please try invoking the API with diplayInFrame: false and see if this resolves the issue?
As per our internal investigation, the url "https://fire.chilipiper.io/" is getting redirected to an auth page and the recommendation is that "You should not use displayInIframe: true if the dialog box will at any point redirect to a page that can't be opened in an iframe. For example, the sign in pages of many popular web services, such as Google and Microsoft account, can't be opened in an iframe".

Also find use the attached code snippet to check if the API is returning any error on execution.
` const dialogUrl = "https://fire.chilipiper.io";

Office.context.ui.displayDialogAsync(dialogUrl, { height: 50, width: 50, displayInIframe: false, promptBeforeOpen: false }, (result) => {
if (result.status === Office.AsyncResultStatus.Succeeded) {
const dialog = result.value;
console.log("Dialog opened successfully:", dialog);
} else {
console.error("Failed to open dialog:", result.error);
}
});`

@anjalitp anjalitp added the Needs: author feedback Waiting for author (creator) of Issue to provide more info label Feb 26, 2025
@pietrofxq
Copy link
Author

@pietrofxq Could you please try invoking the API with diplayInFrame: false and see if this resolves the issue? As per our internal investigation, the url "https://fire.chilipiper.io/" is getting redirected to an auth page and the recommendation is that "You should not use displayInIframe: true if the dialog box will at any point redirect to a page that can't be opened in an iframe. For example, the sign in pages of many popular web services, such as Google and Microsoft account, can't be opened in an iframe".

Also find use the attached code snippet to check if the API is returning any error on execution. ` const dialogUrl = "https://fire.chilipiper.io";

Office.context.ui.displayDialogAsync(dialogUrl, { height: 50, width: 50, displayInIframe: false, promptBeforeOpen: false }, (result) => { if (result.status === Office.AsyncResultStatus.Succeeded) { const dialog = result.value; console.log("Dialog opened successfully:", dialog); } else { console.error("Failed to open dialog:", result.error); } });`

Hello Anjali, the issue remains the same. I am logged in in our service so there is no redirect and the issue still happens

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: attention 👋 Waiting on Microsoft to provide feedback and removed Needs: author feedback Waiting for author (creator) of Issue to provide more info labels Feb 26, 2025
@mmanjaree-msft
Copy link

@pietrofxq Can you please share a recording of the issue. Also do you see the issue when you use the display dialog api without any redirection? Can you try and share this info?

@mmanjaree-msft mmanjaree-msft added Needs: author feedback Waiting for author (creator) of Issue to provide more info and removed Needs: attention 👋 Waiting on Microsoft to provide feedback labels Mar 9, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: no recent activity Issue or PR is stale (no recent activity) label Mar 13, 2025
Copy link
Contributor

This issue has been automatically marked as stale because it is marked as needing author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your interest in Office Add-ins!

Copy link
Contributor

This issue has been closed due to inactivity. Please comment if you still need assistance and we'll re-open the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Outlook Issue related to Outlook add-ins Needs: author feedback Waiting for author (creator) of Issue to provide more info Status: in backlog Issue is being tracked in the backlog but timeline for resolution is unknown Status: no recent activity Issue or PR is stale (no recent activity)
Projects
None yet
Development

No branches or pull requests

6 participants