update geth pin to include pathdb rpc changes + enabling pathdb archival mode for tests + added tests #3945

magicxyyz · 2025-11-03T16:36:01Z

github-actions · 2025-11-03T17:09:49Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
2164	2	2162	0

View the top 2 failed tests by shortest run time

TestVersion30

Stack Traces | 5.250s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
�[38;5;48;1myay!! we validated block 60 in 184.53ms�[0;0m
�[38;5;48;1myay!! we validated block 61 in 89.83ms�[0;0m
    precompile_inclusion_test.go:90: goroutine 455170 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c1170, 0xc07943ce00}, {0x407ebc0, 0xc122a80840}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc07943ce00, {0x407ebc0, 0xc122a80840}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1759 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc07943ce00, 0x1e, {0xc095971db0, 0x6, 0xc002000008?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc07943ce00?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc07943ce00, 0x3d07630)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (5.25s)

TestTimeboostExpressLaneTransactionHandling

Stack Traces | 29.840s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=16   size=3.24KiB   time="32.321µs"  gcnodes=741   gcsize=141.26KiB  gctime=2.196523ms  livenodes=207   livesize=41.43KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=17   size=3.35KiB   time="33.513µs"  gcnodes=758   gcsize=144.61KiB  gctime=2.229956ms  livenodes=190   livesize=38.08KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=16   size=3.21KiB   time="32.371µs"  gcnodes=774   gcsize=147.82KiB  gctime=2.262217ms  livenodes=174   livesize=34.87KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=16   size=3.25KiB   time="38.883µs"  gcnodes=790   gcsize=151.07KiB  gctime=2.30099ms   livenodes=158   livesize=31.62KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=16   size=3.25KiB   time="35.517µs"  gcnodes=806   gcsize=154.32KiB  gctime=2.336417ms  livenodes=142   livesize=28.37KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=24   size=4.62KiB   time="56.916µs"  gcnodes=830   gcsize=158.95KiB  gctime=2.393223ms  livenodes=118   livesize=23.74KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=18   size=3.59KiB   time="39.334µs"  gcnodes=848   gcsize=162.54KiB  gctime=2.432477ms  livenodes=100   livesize=20.15KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=19   size=3.60KiB   time="40.035µs"  gcnodes=867   gcsize=166.13KiB  gctime=2.472422ms  livenodes=81    livesize=16.56KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=16   size=3.25KiB   time="34.104µs"  gcnodes=883   gcsize=169.39KiB  gctime=2.506426ms  livenodes=65    livesize=13.30KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=16   size=3.25KiB   time="31.008µs"  gcnodes=899   gcsize=172.64KiB  gctime=2.537344ms  livenodes=49    livesize=10.05KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=16   size=3.38KiB   time="33.503µs"  gcnodes=915   gcsize=176.02KiB  gctime=2.570757ms  livenodes=33    livesize=6.67KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=17   size=3.38KiB   time="35.166µs"  gcnodes=932   gcsize=179.40KiB  gctime=2.605832ms  livenodes=16    livesize=3.29KiB
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=16   size=3.29KiB   time="31.449µs"  gcnodes=948   gcsize=182.69KiB  gctime=2.637201ms  livenodes=0     livesize=0.00B
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=0    size=0.00B     time=180ns       gcnodes=948   gcsize=182.69KiB  gctime=2.637291ms  livenodes=0     livesize=0.00B
DEBUG[11-07|17:33:36.253] Dereferenced trie from memory database   nodes=0    size=0.00B     time=150ns       gcnodes=948   gcsize=182.69KiB  gctime=2.637361ms  livenodes=0     livesize=0.00B
INFO [11-07|17:33:36.254] Blockchain stopped
DEBUG[11-07|17:33:36.256] redis producer: check responses starting
DEBUG[11-07|17:33:36.256] checkResponses                           responded=0 errored=0 checked=0
TRACE[11-07|17:33:36.257] P2P networking is spinning down
--- FAIL: TestTimeboostExpressLaneTransactionHandling (29.84s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

KolbyML · 2025-11-03T22:23:25Z

@magicxyyz do you want to review the test I added.

Before your fix running my test, I get

missing trie node 5d9533fe4882b4c104ebd0417a3733613df52014d0b2488cc4a1b4ee097ee3d7 (path ) state 0x5d9533fe4882b4c104ebd0417a3733613df52014d0b2488cc4a1b4ee097ee3d7 is not available, not found

when I applied your fix I get

historical state c99f8d14142057462134509ac8f542d5727755c540416a1b09c11462c8c47ef4 is not available

I can second your fix works as expected 🫡

pmikolajczyk41

LGTM + I confirm that updating the geth pin makes this test pass (for the old pin it fails for me with missing trie node as expected)

system_tests/archival_path_scheme_test.go

KolbyML · 2025-11-04T20:57:10Z

@magicxyyz suggested I added a test for Archival mode as well, so I will add that quick

KolbyML · 2025-11-05T23:00:27Z

This PR will be blocked until #3932 is merged

joshuacolvin0

LGTM

KolbyML

looks good

The merge-base changed after approval.

joshuacolvin0

LGTM

KolbyML · 2025-11-07T08:07:00Z

Ah ok I see a few tests are failing which only support the hashdb scheme, that is an easy fix for CI. I will do it when I wake up

KolbyML · 2025-11-07T17:40:14Z

Nice all the tests pass now

magicxyyz added 3 commits October 29, 2025 21:19

allow enabling archive mode for path scheme

4fe7433

simplify state scheme config options

147ad01

warn when state-history not zero and archive mode enabled

0bf94f0

magicxyyz and others added 3 commits November 3, 2025 19:33

remove TestInvalidArchiveConfig as we now allow pathdb archive

666224c

Merge branch 'master' into path-archive-config

c148375

Merge branch 'master' into path-archive-config

5b3b19a

KolbyML requested review from amsanghi, ganeshvanahalli and pmikolajczyk41 November 3, 2025 22:18

KolbyML assigned magicxyyz Nov 3, 2025

KolbyML force-pushed the historical-state-pathdb branch from cda281f to c7e89d2 Compare November 3, 2025 22:32

KolbyML marked this pull request as ready for review November 3, 2025 23:06

KolbyML mentioned this pull request Nov 3, 2025

arbitrum: use historical state reader with pathdb when handling rpc OffchainLabs/go-ethereum#570

Merged

amsanghi previously approved these changes Nov 4, 2025

View reviewed changes

pmikolajczyk41 previously approved these changes Nov 4, 2025

View reviewed changes

system_tests/archival_path_scheme_test.go Show resolved Hide resolved

system_tests/archival_path_scheme_test.go Show resolved Hide resolved

KolbyML dismissed stale reviews from pmikolajczyk41 and amsanghi via d167e39 November 5, 2025 22:59

magicxyyz and others added 3 commits November 5, 2025 16:00

update geth pin to include pathdb rpc changes

923e269

Add a system_test for fix for "missing trie node error on pathdb nodes"

aad0402

Add test for PathDB Archival Mode

37bf5a3

KolbyML force-pushed the historical-state-pathdb branch from d167e39 to 37bf5a3 Compare November 5, 2025 23:01

joshuacolvin0 added 2 commits November 6, 2025 20:01

Merge branch 'master' into historical-state-pathdb

05cb92a

update geth pin

e1a3aa2

joshuacolvin0 previously approved these changes Nov 7, 2025

View reviewed changes

joshuacolvin0 added the design-approved label Nov 7, 2025

joshuacolvin0 enabled auto-merge November 7, 2025 03:08

joshuacolvin0 enabled auto-merge November 7, 2025 03:40

KolbyML previously approved these changes Nov 7, 2025

View reviewed changes

joshuacolvin0 added this pull request to the merge queue Nov 7, 2025

joshuacolvin0 removed this pull request from the merge queue due to a manual request Nov 7, 2025

Merge branch 'master' into historical-state-pathdb

04b302a

joshuacolvin0 previously approved these changes Nov 7, 2025

View reviewed changes

joshuacolvin0 enabled auto-merge November 7, 2025 04:07

joshuacolvin0 added this pull request to the merge queue Nov 7, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2025

Merge branch 'master' into historical-state-pathdb

6eef58d

joshuacolvin0 enabled auto-merge November 7, 2025 14:59

joshuacolvin0 disabled auto-merge November 7, 2025 15:00

fix warning + make hashdb tests not run pathdb

84f7a5d

KolbyML dismissed joshuacolvin0’s stale review via 84f7a5d November 7, 2025 16:29

Merge branch 'master' into historical-state-pathdb

d020d6f

KolbyML changed the title ~~update geth pin to include pathdb rpc changes~~ update geth pin to include pathdb rpc changes + enabling pathdb archival mode for tests + added tests Nov 7, 2025

KolbyML added 2 commits November 7, 2025 09:54

restrain more tests

af4a4f8

Update triedb_race_test.go

640014e

eljobe approved these changes Nov 7, 2025

View reviewed changes

KolbyML added this pull request to the merge queue Nov 7, 2025

KolbyML removed this pull request from the merge queue due to a manual request Nov 7, 2025

KolbyML added this pull request to the merge queue Nov 7, 2025

KolbyML removed this pull request from the merge queue due to a manual request Nov 7, 2025

KolbyML added this pull request to the merge queue Nov 7, 2025

Merged via the queue into master with commit cbf4755 Nov 7, 2025
23 checks passed

KolbyML deleted the historical-state-pathdb branch November 7, 2025 19:23

update geth pin to include pathdb rpc changes + enabling pathdb archival mode for tests + added tests #3945

update geth pin to include pathdb rpc changes + enabling pathdb archival mode for tests + added tests #3945

Uh oh!

Conversation

magicxyyz commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 2 Tests Failed:

Uh oh!

KolbyML commented Nov 3, 2025

Uh oh!

pmikolajczyk41 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

KolbyML commented Nov 4, 2025

Uh oh!

KolbyML commented Nov 5, 2025

Uh oh!

joshuacolvin0 left a comment

Choose a reason for hiding this comment

Uh oh!

KolbyML left a comment

Choose a reason for hiding this comment

Uh oh!

joshuacolvin0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

KolbyML commented Nov 7, 2025

Uh oh!

KolbyML commented Nov 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

magicxyyz commented Nov 3, 2025 •

edited

Loading

github-actions bot commented Nov 3, 2025 •

edited

Loading