Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tipping tx subtype #1901

Closed
wants to merge 73 commits into from
Closed

Add tipping tx subtype #1901

wants to merge 73 commits into from

Conversation

magicxyyz
Copy link
Contributor

This PR:

  • makes use ofArbitrumTippingTx
  • adds tests for tipping tx

needs: OffchainLabs/go-ethereum#260

magicxyyz and others added 27 commits February 27, 2023 18:09
@magicxyyz
add extended tx transaction type support
e853315
@magicxyyz
update go-ethereum submodule
abf275f
@magicxyyz
update go-ethereum submodule
84f87ae
@magicxyyz
fix DropTip method
f2339c9
@magicxyyz
Merge branch 'master' into tipping-tx-type
1da1a1f
@magicxyyz
update go-ethereum submodule
2c5e287
@magicxyyz
add initial tipping tx tests
331aac3
@magicxyyz
use ArbitrumSubtypedTx, add more tipping tx tests
837fbb4
@magicxyyz
Merge branch 'master' into tipping-tx-type
d3af533
@magicxyyz
update go-ethereum
d55890d
@magicxyyz
move compressedTxSize to testhelpers
b5379c0
@magicxyyz
Revert "move compressedTxSize to testhelpers"
ada4231 
This reverts commit b5379c0.
@magicxyyz
make a local copy of compressesTxSize helper
58db91e
@magicxyyz
add json marshalling test for tipping tx
c6e5250
@magicxyyz
Merge branch 'master' into tipping-tx-type
f929384
@magicxyyz
check in preTxFilter unsupported ArbitrumSubtypedTxType for arbos ver…
15d90de 
…sion < 11
@magicxyyz
check for unsupported ArbitrumSubtypedTx in tx pre checker
ebe26a5
@magicxyyz
Merge branch 'master' into tipping-tx-type
f647d8e
@magicxyyz
Merge branch 'master' into tipping-tx-type
273f60b
@magicxyyz
Merge branch 'master' into tipping-tx-type
8b047fd
@rauljordan
update geth commit
3557f58
@rauljordan
sync master
6ab03f6
@rauljordan
sequencer changes
b3c3b22
@rauljordan
add contracts
8776240
@rauljordan
update sub
fcf2c83
@rauljordan
fix conflicts
599f97b
@rauljordan
network fee check
fe73259
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 2, 2023
@magicxyyz magicxyyz mentioned this pull request Oct 2, 2023
Closed
@joshuacolvin0 joshuacolvin0 added the geth Involves changes to Go-Ethereum label Nov 30, 2023
@magicxyyz magicxyyz marked this pull request as ready for review December 11, 2023 23:59
@notion-workspace Notion Workspace
Copy link

Add a new transaction type that we accept tips from

@magicxyyz magicxyyz requested a review from PlasmaPower January 9, 2024 04:05
@magicxyyz magicxyyz marked this pull request as draft November 18, 2024 13:47
@magicxyyz
Copy link
Contributor Author

we went with a different approach for now

@magicxyyz magicxyyz closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower Awaiting requested review from PlasmaPower

Assignees
No one assigned
Labels
geth Involves changes to Go-Ethereum s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicxyyz @joshuacolvin0 @rauljordan