Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

garbage collect not commited tries #261

Merged
merged 8 commits into from
Oct 18, 2023
Merged

garbage collect not commited tries #261

merged 8 commits into from
Oct 18, 2023

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Oct 5, 2023 •
edited
Loading

  • adds missing garbage collection of not committed states when running archive node that skips saving some states
  • adds acquiring db lock before accessing dirties map in hashdb/Database.commit to fix race Database.commit vs Database.dereference
  • fixes committing oldest node from triegc in BlockChain.Stop

@cla-bot cla-bot bot added the s CLA signed label Oct 5, 2023
@magicxyyz magicxyyz mentioned this pull request Oct 11, 2023
Merged
@magicxyyz magicxyyz force-pushed the fix-skipped-state-gc branch from 2c6815b to 202caf5 Compare October 11, 2023 21:41
@magicxyyz magicxyyz marked this pull request as ready for review October 11, 2023 22:20
ganeshvanahalli
ganeshvanahalli approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshuacolvin0 joshuacolvin0 merged commit 5d9bb83 into master Oct 18, 2023
4 checks passed
@joshuacolvin0 joshuacolvin0 deleted the fix-skipped-state-gc branch October 18, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshvanahalli ganeshvanahalli ganeshvanahalli approved these changes

Assignees
No one assigned
Labels
s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicxyyz @ganeshvanahalli @joshuacolvin0