Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling of batch pushResponse #259

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix error handling of batch pushResponse #259

merged 1 commit into from
Sep 28, 2023

Conversation

PlasmaPower
Copy link
Collaborator

#258 will eventually have a better fix, but in the meantime, this fixes the error handling by using the higher level callBuffer instead of h.conn.writeJSON

@cla-bot cla-bot bot added the s CLA signed label Sep 28, 2023
magicxyyz
magicxyyz approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 921163a into master Sep 28, 2023
2 checks passed
@PlasmaPower PlasmaPower deleted the fix-batch-response-error branch September 28, 2023 22:23
@PlasmaPower PlasmaPower mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicxyyz magicxyyz magicxyyz approved these changes

Assignees
No one assigned
Labels
s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PlasmaPower @magicxyyz