Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contract size limit configurable #255

Merged
merged 16 commits into from
Oct 25, 2023

Conversation

ganeshvanahalli
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the s CLA signed label Sep 21, 2023
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple minor comments on the chain config part but the use of the new parameter looks perfect

params/config_arbitrum.go Outdated Show resolved Hide resolved
params/config_arbitrum.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 859182f into master Oct 25, 2023
2 checks passed
@PlasmaPower PlasmaPower deleted the configure-maxcodesize-chainconfig branch October 25, 2023 22:30
joshuacolvin0 added a commit to OffchainLabs/nitro that referenced this pull request Oct 26, 2023
Tristan-Wilson added a commit that referenced this pull request Oct 31, 2023
Conflicts:
	core/txpool/txpool.go
We added max code size to ChainConfig on master (#255) and this conflicted with
upstream changes to refactoring txpool. Resolved by putting the check in
ValidateTransaction in the file it was moved to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s CLA signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants