Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Rinkeby testnet params #202

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Remove Rinkeby testnet params #202

merged 2 commits into from
Sep 29, 2023

Conversation

rachel-bousfield
Copy link
Contributor

Drops the Rinkeby config now that we're no longer supporting it

joshuacolvin0
joshuacolvin0 previously approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachel-bousfield
Copy link
Contributor Author

Let's hold off on merging until we discuss this later, but here's the quick PR should we want to

@cla-bot cla-bot bot added the s CLA signed label Sep 29, 2023
joshuacolvin0
joshuacolvin0 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit abfeebc into master Sep 29, 2023
2 checks passed
@tsahee tsahee deleted the remove-rinkeby-params branch November 28, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachel-bousfield @joshuacolvin0