-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add OctoRelay plugin #821
add OctoRelay plugin #821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments below, mostly just related to wrong id for plugin repo submission. I do have one concern related to your default settings. It seems that you are linking directly to your github repo for image assets. Wouldn't it be better to include those in your plugin's static folder and link to them that way instead? I can assist you with what that URL would be if you would like to go that route.
I submitte PR #1 to your repo for a better way to handle the icons versus linking to github. I think once that's merged we should be good to go with approving this PR and getting you on the repo. |
Just wanted to give you a heads up for future development @borisbu that you will want to publish a release on your github based on the current master branch, and then with future updates you modify the setup.py version number and release a new version in github and everyone with your plugin installed will get the updates as expected. |
please add the plugin to the Plugin repository